Skip to content

update doom-value-adjustment due to recent patch#11140

Merged
pajlada merged 1 commit intorunelite:masterfrom
joffewilliam:doom-value-adjustment
Mar 23, 2026
Merged

update doom-value-adjustment due to recent patch#11140
pajlada merged 1 commit intorunelite:masterfrom
joffewilliam:doom-value-adjustment

Conversation

@joffewilliam
Copy link
Copy Markdown
Contributor

I suppose its either good timing or my plugin got jagex's attention. They patched Sun-kissed bone value.
I now give the option to use the inferred value of the bones and added support for changing spirit seeds to be worth 0 gp or the average value of a tier 5 seed pack. Both options are initialized at a default setting.

@runelite-github-app
Copy link
Copy Markdown

@runelite-github-app
Copy link
Copy Markdown

Internal use only: Reviewer details Maintainer details

@pajlada
Copy link
Copy Markdown
Contributor

pajlada commented Mar 22, 2026

Your change to the bonesValuation config will essentially reset the setting the user has selected, if you're doing a rename it would be more user-friendly if you also migrate their settings. Another alternative is to keep the two settings you had (0gp and approximate) and add the new Default option.

@pajlada pajlada added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 22, 2026
@joffewilliam
Copy link
Copy Markdown
Contributor Author

Your change to the bonesValuation config will essentially reset the setting the user has selected, if you're doing a rename it would be more user-friendly if you also migrate their settings. Another alternative is to keep the two settings you had (0gp and approximate) and add the new Default option.

Jagex patched that functionality in the latest game update. 0gp is default value for sun kissed bones in game now. I figured it would be best to clear the config because of the change. Please advise. I'll do whatever you think is best. I didn't want to have 0gp and default as an option with no change seen between the options.

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 22, 2026
@pajlada
Copy link
Copy Markdown
Contributor

pajlada commented Mar 23, 2026

Your change to the bonesValuation config will essentially reset the setting the user has selected, if you're doing a rename it would be more user-friendly if you also migrate their settings. Another alternative is to keep the two settings you had (0gp and approximate) and add the new Default option.

Jagex patched that functionality in the latest game update. 0gp is default value for sun kissed bones in game now. I figured it would be best to clear the config because of the change. Please advise. I'll do whatever you think is best. I didn't want to have 0gp and default as an option with no change seen between the options.

That's all good then, as long as you've given thought to the change I'm happy to merge this in.

@pajlada pajlada merged commit fc24ebd into runelite:master Mar 23, 2026
3 checks passed
CCatRS pushed a commit to CCatRS/plugin-hub that referenced this pull request Apr 2, 2026
Lexer747 pushed a commit to Lexer747/plugin-hub that referenced this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants