Skip to content

Vec::from_array now const#644

Open
tower120 wants to merge 3 commits intorust-embedded:mainfrom
tower120:const_vec_from_array
Open

Vec::from_array now const#644
tower120 wants to merge 3 commits intorust-embedded:mainfrom
tower120:const_vec_from_array

Conversation

@tower120
Copy link
Copy Markdown

@tower120 tower120 commented Jan 28, 2026 •
edited
Loading

Implements #643

zeenix
zeenix requested changes Jan 28, 2026
View reviewed changes
@tower120
Copy link
Copy Markdown
Author

tower120 commented Jan 29, 2026 •
edited
Loading

@zeenix Do you see these comments?
image

UPDATE: Sorry - it turns out "pending" means pending MY approval to send review comments.
I initially thought it was "pending" for maintainer approval to make them visible for everyone.

tower120
tower120 commented Jan 29, 2026
View reviewed changes
@rust-embedded rust-embedded deleted a comment from tower120 Jan 29, 2026
sgued
sgued requested changes Jan 29, 2026
View reviewed changes
@tower120
Copy link
Copy Markdown
Author

tower120 commented Jan 29, 2026

BTW, why explicit u64 is not supported as LenType?

@tower120
Copy link
Copy Markdown
Author

tower120 commented Jan 29, 2026

Also, I see in some places LenType is lentype, in other it is len_type.
Which convention should I follow?

@sgued
Copy link
Copy Markdown
Contributor

sgued commented Jan 30, 2026

u64 doesn't make much sense because usize would always be a better option.

@sgued
Copy link
Copy Markdown
Contributor

sgued commented Jan 30, 2026

You should use len_type. We should probably unify it everywhere to LenType and len_type removing lentype which doesn't match Rust's naming conventions.

@tower120
Copy link
Copy Markdown
Author

tower120 commented Jan 30, 2026

OK. Then everything good as it is.

@tower120 tower120 requested review from sgued and zeenix January 30, 2026 09:36
reitermarkus
reitermarkus reviewed Jan 30, 2026
View reviewed changes
reitermarkus
reitermarkus reviewed Jan 30, 2026
View reviewed changes
reitermarkus
reitermarkus reviewed Jan 30, 2026
View reviewed changes
reitermarkus
reitermarkus reviewed Jan 30, 2026
View reviewed changes
@tower120 tower120 requested a review from reitermarkus January 30, 2026 16:43
@tower120
Copy link
Copy Markdown
Author

tower120 commented Feb 6, 2026

So, do you need something from my side to move this forward?

zeenix
zeenix reviewed Feb 7, 2026
View reviewed changes
zeenix
zeenix previously approved these changes Feb 7, 2026
View reviewed changes
@zeenix zeenix enabled auto-merge February 7, 2026 15:47
sgued
sgued previously approved these changes Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sgued sgued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I left this and was the one blocking the merge. Just needs a squash and we can merge it.

@zeenix zeenix added this pull request to the merge queue Mar 28, 2026
@sgued sgued removed this pull request from the merge queue due to a manual request Mar 28, 2026
@sgued sgued dismissed stale reviews from zeenix and themself via 666a0ac March 28, 2026 20:30
@sgued sgued force-pushed the const_vec_from_array branch from 709f18a to 666a0ac Compare March 28, 2026 20:30
@sgued sgued enabled auto-merge March 28, 2026 20:30
@sgued sgued force-pushed the const_vec_from_array branch from 0656d92 to 6bb5909 Compare March 28, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeenix zeenix zeenix left review comments

@sgued sgued sgued left review comments

@reitermarkus reitermarkus Awaiting requested review from reitermarkus

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tower120 @sgued @zeenix @reitermarkus