build: add rust-toolchain.toml file#5128
Open
dybucc wants to merge 1 commit into
Open
Conversation
Previously, one would have to manually set an override in `rustup` for the `libc` repo if they weren't already using `nightly` as their default toolchain channel. This meant stuff that relies on unstable features like our `.rustfmt.toml` config would not work in those cases. Adding a `rust-toolchain.toml` should fix this by either automatically switching users to the `nightly` channel, or triggering a `rustup install` if their installation does not yet include it.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
At present, one is either required to already have the
nightlytoolchain set as default in theirrustup set up, or otherwise configure a manual override with
rustup override set. This makes it sothat stuff like autoformatting through
rustfmtfails, as the.rustfmt.tomlfile is configuredwith unstable features.
This commit adds a
rust-toolchain.tomlfile that makes it so that the user will be reported asrequiring to add the corresponding component when calling, among others,
cargo fmt, or otherwisewill silently perform the operation by switching to the
nightlychannel.Because this has some slight consequences to some CI jobs, this patch includes changes there as
well.
Note it may be preferable to also add a list of components to make a single failed
cargocommandautomtically install all components the
libccrate requires, but I've left that out for the timebeing.
Sources
None
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI