Replace some span_lint_and_then calls with span_lint_and_sugg#5484
Closed
phansch wants to merge 1 commit into
Closed
Replace some span_lint_and_then calls with span_lint_and_sugg#5484phansch wants to merge 1 commit into
span_lint_and_then calls with span_lint_and_sugg#5484phansch wants to merge 1 commit into
Conversation
phansch
added
the
S-waiting-on-review
Member
|
@xiongmao86 is way ahead of you #5141 😛 I'd rather wait for the completion of #5141 instead of merging this, since that is close to completion. |
Contributor
Author
|
Oh, that's awesome! I'll close this PR then 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could probably be linted: It was me essentially checking if
span_lint_and_then's closure only contains the call tospan_suggestionand ensuring that both spans were the same.changelog: none