Skip to content

ci: Add dist-aarch64-freebsd#154265

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
mrkajetanp:freebsd-aarch64-ci
May 19, 2026
Merged

ci: Add dist-aarch64-freebsd#154265
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
mrkajetanp:freebsd-aarch64-ci

Conversation

@mrkajetanp
Copy link
Copy Markdown
Contributor

@mrkajetanp mrkajetanp commented Mar 23, 2026 •
edited by rustbot
Loading

View all comments

Add scripts to build the aarch64-unknown-freebsd target in CI.
Implements MCP: rust-lang/compiler-team#961

There is currently the issue of FreeBSD version support. See the following thread for more details:
#132228

The current version supported by rust is FreeBSD 12, which is already EOL. This means it is no longer possible to download FreeBSD releases from their servers. The aarch64 build is not mirrored on the Rust servers, which is why I couldn't match the version used by already existing CI scripts and had to change this one to FreeBSD 13. FreeBSD 13 itself will be EOL a month from now, on April 30th. We might want to put aarch64 FreeBSD builds on the Rust mirror and update the support across the board to FreeBSD 14 prior to merging this.

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 23, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 23, 2026

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: infra-ci
  • infra-ci expanded to Kobzol, Mark-Simulacrum, jdno, jieyouxu, marcoieni
  • Random selection from Mark-Simulacrum, jdno, jieyouxu, marcoieni

@mrkajetanp
Copy link
Copy Markdown
Contributor Author

mrkajetanp commented Mar 23, 2026

@asomers @devnexen @workingjubilee

@asomers
Copy link
Copy Markdown
Contributor

asomers commented Mar 23, 2026

This is awesome, @mrkajetanp . And I for one would support raising the minimum supported version to FreeBSD 13.

@marcoieni
Copy link
Copy Markdown
Member

marcoieni commented Mar 24, 2026

you can add files to our mirrors at https://github.com/rust-lang/ci-mirrors

@mrkajetanp mrkajetanp mentioned this pull request Mar 25, 2026
Merged
@mrkajetanp
Copy link
Copy Markdown
Contributor Author

mrkajetanp commented Mar 25, 2026

you can add files to our mirrors at https://github.com/rust-lang/ci-mirrors

Ah good to know, thanks!

homersimpsons
homersimpsons reviewed Mar 27, 2026
View reviewed changes
Comment thread src/ci/docker/host-aarch64/dist-aarch64-freebsd/Dockerfile Outdated
homersimpsons
homersimpsons approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@homersimpsons homersimpsons left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me (regarding the thread I opened), but I have no power here, still approving.

View changes since this review

@nohajc
Copy link
Copy Markdown

nohajc commented May 13, 2026

Would love to see this merged soon. Great that you're working on it!

marcoieni
marcoieni reviewed May 13, 2026
View reviewed changes
Comment thread src/ci/docker/scripts/freebsd-toolchain.sh Outdated
@marcoieni
Copy link
Copy Markdown
Member

marcoieni commented May 13, 2026

shouldn't we also add a job in https://github.com/rust-lang/rust/blob/main/src/ci/github-actions/jobs.yml ? Otherwise this will never get triggered in CI, right? 🤔

marcoieni
marcoieni reviewed May 13, 2026
View reviewed changes
Comment thread src/ci/docker/host-aarch64/dist-aarch64-freebsd/Dockerfile Outdated
This was referenced May 13, 2026
Merged
Merged
@mrkajetanp
Copy link
Copy Markdown
Contributor Author

mrkajetanp commented May 15, 2026

I think the clean way is probably to first do a version bump to FreeBSD 14 for existing platforms, then rebase this and make it just a clean addition of aarch64 without messing with the versions. Hence the PR linked above.

@rust-bors

This comment has been minimized.

Sign in to view
@mrkajetanp mrkajetanp force-pushed the freebsd-aarch64-ci branch from 8b6b8f0 to c542d80 Compare May 18, 2026 11:15
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 18, 2026

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 18, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@mrkajetanp mrkajetanp requested a review from marcoieni May 18, 2026 11:16
marcoieni
marcoieni reviewed May 18, 2026
View reviewed changes
Comment thread src/ci/github-actions/jobs.yml Outdated
@mrkajetanp
ci: Add dist-aarch64-freebsd
52b5f55 
Add scripts to build the aarch64-unknown-freebsd target in CI.
Implements MCP: rust-lang/compiler-team#961
@mrkajetanp mrkajetanp force-pushed the freebsd-aarch64-ci branch from c542d80 to 52b5f55 Compare May 18, 2026 12:46
@mrkajetanp mrkajetanp requested a review from marcoieni May 18, 2026 12:46
@marcoieni
Copy link
Copy Markdown
Member

marcoieni commented May 18, 2026

@bors try jobs=dist-aarch64-freebsd

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request May 18, 2026
@bors
Auto merge of #154265 - mrkajetanp:freebsd-aarch64-ci, r=<try>
66785cc 
ci: Add dist-aarch64-freebsd


try-job: dist-aarch64-freebsd
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 18, 2026

☀️ Try build successful (CI)
Build commit: 66785cc (66785cc7bc88586f6aa8cfafc17a4b276e2885df, parent: 5ea817c65e4896167300b7d2550781b98da9901a)

@marcoieni
Copy link
Copy Markdown
Member

marcoieni commented May 19, 2026

Do the artifacts look good to you? If yes, I will approve 👍

@mrkajetanp
Copy link
Copy Markdown
Contributor Author

mrkajetanp commented May 19, 2026

Do the artifacts look good to you? If yes, I will approve 👍

I tried them on my machine, they look good!

@marcoieni
Copy link
Copy Markdown
Member

marcoieni commented May 19, 2026

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 19, 2026

📌 Commit 52b5f55 has been approved by marcoieni

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 19, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request May 19, 2026
@bors
Auto merge of #156751 - JonathanBrouwer:rollup-jecv0TQ, r=JonathanBro…
7f1e9f4 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #154265 (ci: Add dist-aarch64-freebsd)
 - #156739 (miri subtree update)
 - #148666 (Add support for xray in aarch64 unknown none targets)
 - #156547 (Move tests closures)
 - #156578 (Add FileCheck for build_correct_coerce)
 - #156734 ([rustdoc] Move `span_map` file to the right folder)
rust-bors Bot pushed a commit that referenced this pull request May 19, 2026
@bors
Auto merge of #156751 - JonathanBrouwer:rollup-jecv0TQ, r=JonathanBro…
3b2bdff 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #154265 (ci: Add dist-aarch64-freebsd)
 - #156739 (miri subtree update)
 - #148666 (Add support for xray in aarch64 unknown none targets)
 - #156547 (Move tests closures)
 - #156578 (Add FileCheck for build_correct_coerce)
 - #156734 ([rustdoc] Move `span_map` file to the right folder)
rust-bors Bot pushed a commit that referenced this pull request May 19, 2026
@bors
Auto merge of #156751 - JonathanBrouwer:rollup-jecv0TQ, r=JonathanBro…
f7e11ea 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #154265 (ci: Add dist-aarch64-freebsd)
 - #156739 (miri subtree update)
 - #148666 (Add support for xray in aarch64 unknown none targets)
 - #156547 (Move tests closures)
 - #156578 (Add FileCheck for build_correct_coerce)
 - #156734 ([rustdoc] Move `span_map` file to the right folder)
rust-bors Bot pushed a commit that referenced this pull request May 19, 2026
@bors
Auto merge of #156751 - JonathanBrouwer:rollup-jecv0TQ, r=JonathanBro…
1ea1171 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #154265 (ci: Add dist-aarch64-freebsd)
 - #156739 (miri subtree update)
 - #148666 (Add support for xray in aarch64 unknown none targets)
 - #156547 (Move tests closures)
 - #156578 (Add FileCheck for build_correct_coerce)
 - #156734 ([rustdoc] Move `span_map` file to the right folder)
@rust-bors rust-bors Bot merged commit d14790a into rust-lang:main May 19, 2026
12 checks passed
@rustbot rustbot added this to the 1.97.0 milestone May 19, 2026
rust-timer added a commit that referenced this pull request May 19, 2026
@rust-timer
Unrolled build for #154265
4d50462 
Rollup merge of #154265 - mrkajetanp:freebsd-aarch64-ci, r=marcoieni

ci: Add dist-aarch64-freebsd

Add scripts to build the aarch64-unknown-freebsd target in CI.
Implements MCP: rust-lang/compiler-team#961

There is currently the issue of FreeBSD version support. See the following thread for more details:
#132228

The current version supported by rust is FreeBSD 12, which is already EOL. This means it is no longer possible to download FreeBSD releases from their servers. The aarch64 build is not mirrored on the Rust servers, which is why I couldn't match the version used by already existing CI scripts and had to change this one to FreeBSD 13. FreeBSD 13 itself will be EOL a month from now, on April 30th. We might want to put aarch64 FreeBSD builds on the Rust mirror and update the support across the board to FreeBSD 14 prior to merging this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoieni marcoieni Awaiting requested review from marcoieni

1 more reviewer

@homersimpsons homersimpsons homersimpsons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marcoieni marcoieni

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

6 participants

@mrkajetanp @rustbot @asomers @marcoieni @nohajc @homersimpsons