Skip to content

Add FileCheck for build_correct_coerce#156578

Open
eval-exec wants to merge 1 commit into
rust-lang:mainfrom
eval-exec:mir-opt-build-correct-coerce-filecheck
Open

Add FileCheck for build_correct_coerce#156578
eval-exec wants to merge 1 commit into
rust-lang:mainfrom
eval-exec:mir-opt-build-correct-coerce-filecheck

Conversation

@eval-exec
Copy link
Copy Markdown
Contributor

@eval-exec eval-exec commented May 14, 2026 •
edited by rustbot
Loading

part of #116971

Copilot AI review requested due to automatic review settings May 14, 2026 16:31
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 14, 2026

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

Copilot AI reviewed May 14, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds inline FileCheck assertions to the existing MIR optimization regression test for build_correct_coerce, enabling automated validation of the expected coercion target in generated MIR.

Changes:

  • Removed //@ skip-filecheck.
  • Added FileCheck expectations for main to assert the coerced function pointer type and assignment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@TaKO8Ki
Copy link
Copy Markdown
Member

TaKO8Ki commented May 19, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 19, 2026

📌 Commit 61e801d has been approved by TaKO8Ki

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 19, 2026
@JonathanBrouwer
Rollup merge of rust-lang#156578 - eval-exec:mir-opt-build-correct-co…
3a0c6e9 
…erce-filecheck, r=TaKO8Ki

Add FileCheck for build_correct_coerce

part of rust-lang#116971
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 19, 2026
Open
rust-bors Bot pushed a commit that referenced this pull request May 19, 2026
@bors
Auto merge of #156751 - JonathanBrouwer:rollup-jecv0TQ, r=JonathanBro…
7f1e9f4 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #154265 (ci: Add dist-aarch64-freebsd)
 - #156739 (miri subtree update)
 - #148666 (Add support for xray in aarch64 unknown none targets)
 - #156547 (Move tests closures)
 - #156578 (Add FileCheck for build_correct_coerce)
 - #156734 ([rustdoc] Move `span_map` file to the right folder)
rust-bors Bot pushed a commit that referenced this pull request May 19, 2026
@bors
Auto merge of #156751 - JonathanBrouwer:rollup-jecv0TQ, r=JonathanBro…
3b2bdff 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #154265 (ci: Add dist-aarch64-freebsd)
 - #156739 (miri subtree update)
 - #148666 (Add support for xray in aarch64 unknown none targets)
 - #156547 (Move tests closures)
 - #156578 (Add FileCheck for build_correct_coerce)
 - #156734 ([rustdoc] Move `span_map` file to the right folder)
rust-bors Bot pushed a commit that referenced this pull request May 19, 2026
@bors
Auto merge of #156751 - JonathanBrouwer:rollup-jecv0TQ, r=JonathanBro…
f7e11ea 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #154265 (ci: Add dist-aarch64-freebsd)
 - #156739 (miri subtree update)
 - #148666 (Add support for xray in aarch64 unknown none targets)
 - #156547 (Move tests closures)
 - #156578 (Add FileCheck for build_correct_coerce)
 - #156734 ([rustdoc] Move `span_map` file to the right folder)
rust-bors Bot pushed a commit that referenced this pull request May 19, 2026
@bors
Auto merge of #156751 - JonathanBrouwer:rollup-jecv0TQ, r=JonathanBro…
1ea1171 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #154265 (ci: Add dist-aarch64-freebsd)
 - #156739 (miri subtree update)
 - #148666 (Add support for xray in aarch64 unknown none targets)
 - #156547 (Move tests closures)
 - #156578 (Add FileCheck for build_correct_coerce)
 - #156734 ([rustdoc] Move `span_map` file to the right folder)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@TaKO8Ki TaKO8Ki TaKO8Ki approved these changes

Assignees

@TaKO8Ki TaKO8Ki

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eval-exec @rustbot @TaKO8Ki