Rollup of 3 pull requests#156728
Merged
Merged
Conversation
We need it to be able to build the stdlib, and this has regressed in the recent past.
this is lcnr's solution
test new solver on CI until stabilization We need the new solver to be able to build the stdlib, and this has regressed in the recent past. Things are broken right now, and we want to ensure this keeps working until stabilization later this year. I've added this to the `x86_64-gnu-llvm-XX` job (note no `-1/2/3` suffix) so it's run on PR and auto CI, and because it's roughly the fastest of these builders, though maybe the aarch64 llvm 1 and 2 are slightly faster. Building the stage 1 `./x build library/` is generally quite quick, a couple minutes at most. The new solver fix to build std is from @lcnr [on zulip](https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/weekly.20sync.2Fupdates/near/591998234). r? @marcoieni
…rfonthey prefer `T::IS_ZST` over manual check makes the intent clearer and possible small perf improvement
Update books ## rust-lang/reference 9 commits in 581920f9109f141b88b860b3e1e8359e3896a150..ad35aca481751a06afeb23820a672b0f3b11a476 2026-05-14 17:00:42 UTC to 2026-05-04 18:27:13 UTC - ci: declare contents:read on CI workflow (rust-lang/reference#2271) - Fix the grammar of generic arguments (rust-lang/reference#2247) - Rename grammar rule `TypeParamBounds` to just `Bounds` (rust-lang/reference#2258) - Update `used` to use the attribute template (rust-lang/reference#1905) - Place HRTB binders before fn qualifiers (rust-lang/reference#2260) - Glossary: add new entry documenting zero-sized types (rust-lang/reference#2203) - Fix test failure on macOS with link_section (rust-lang/reference#2246) - Make definition of fragment specifier `path` more precise (rust-lang/reference#2248) - gitignore linkcheck (rust-lang/reference#2252)
rustbot
added
A-CI
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 9eb3be26b4 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 9eb3be2 (parent) -> ca9203f (this PR) Test differencesShow 16 test diffs16 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard ca9203f29c609b344566d4eed9b5d9a3bf10290c --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (ca9203f): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.3%, secondary -4.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 4.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 510.171s -> 513.992s (0.75%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
T::IS_ZSTover manual check #155840 (preferT::IS_ZSTover manual check)r? @ghost
Create a similar rollup