Use print instead of po in debuginfo path test#156769
Conversation
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Reproduced on Apple LLDB 2100.
Submitted a PR replacing |
There was a problem hiding this comment.
Question:
This fixes
tests/debuginfo/path.rsfailing on newer Apple LLDB versions.Root cause:
Apple LLDB 2100 reports missing Rust language plugin support:warning:
powas unsuccessful, runningpinsteadAs a result,
pofalls back top, producing expanded output that no longer matches the existinglldb-checkdirectives.
Changing the test seems a bit weird to me, like this feels like just papering over the actual problem? Do we know why that missing support report happens? Do we know if this failure is strictly (1) due to missing support from a newer lldb version, or (2) due to a recent change, or perhaps both?
There was a problem hiding this comment.
Okay I see, I think this might've been an interaction with #147552
|
Reminder, once the PR becomes ready for a review, use |
|
Thanks, that makes sense. I investigated this further on my side as well. I checked an older revision (
The pretty printers still seem to work correctly through If this is indeed related to #147552, I'm happy to adjust the approach or update the PR accordingly. |
|
The actual root cause is simply that we do not test this version in CI. I believe we test LLDB 1703 now? See
@bors try jobs=aarch64-apple Making the test more tolerant by making it accept virtually anything with the same prefix, when it previously tested for two different output formats, one significantly more verbose than the test checks for, does seem to defeat the purpose of having a test here. |
This comment has been minimized.
This comment has been minimized.
Use print instead of po in debuginfo path test try-job: aarch64-apple
Fixes #156660
This fixes
tests/debuginfo/path.rsfailing on newer Apple LLDB versions.Root cause:
Apple LLDB 2100 reports missing Rust language plugin support:
warning:
powas unsuccessful, runningpinsteadAs a result,
pofalls back top, producing expanded output that no longer matches the existinglldb-checkdirectives.Changes:
powithprintlldb-checkexpectations using[...]This also aligns
path.rswith the rest of the debuginfo tests, as it appears to be the only test usingpo.