Skip to content

Use print instead of po in debuginfo path test#156769

Open
fallofpheonix wants to merge 1 commit into
rust-lang:mainfrom
fallofpheonix:fix-path-lldb-macos
Open

Use print instead of po in debuginfo path test#156769
fallofpheonix wants to merge 1 commit into
rust-lang:mainfrom
fallofpheonix:fix-path-lldb-macos

Conversation

@fallofpheonix
Copy link
Copy Markdown

@fallofpheonix fallofpheonix commented May 20, 2026

Fixes #156660

This fixes tests/debuginfo/path.rs failing on newer Apple LLDB versions.

Root cause:
Apple LLDB 2100 reports missing Rust language plugin support:

warning: po was unsuccessful, running p instead

As a result, po falls back to p, producing expanded output that no longer matches the existing lldb-check directives.

Changes:

  • replace po with print
  • relax lldb-check expectations using [...]
  • preserve validation of the displayed path value

This also aligns path.rs with the rest of the debuginfo tests, as it appears to be the only test using po.

Copilot AI review requested due to automatic review settings May 20, 2026 08:55
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 20, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 20, 2026

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 20 candidates

@fallofpheonix
Copy link
Copy Markdown
Author

Reproduced on Apple LLDB 2100.

po falls back to p because LLDB reports missing Rust language plugin support. path.rs appears to be the only debuginfo test using po.

Submitted a PR replacing po with print and relaxing the checks.

This comment was marked as low quality.

Comment thread tests/debuginfo/path.rs
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question:

This fixes tests/debuginfo/path.rs failing on newer Apple LLDB versions.

Root cause:
Apple LLDB 2100 reports missing Rust language plugin support:

warning: po was unsuccessful, running p instead

As a result, po falls back to p, producing expanded output that no longer matches the existing lldb-check directives.

Changing the test seems a bit weird to me, like this feels like just papering over the actual problem? Do we know why that missing support report happens? Do we know if this failure is strictly (1) due to missing support from a newer lldb version, or (2) due to a recent change, or perhaps both?

View changes since the review

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I see, I think this might've been an interaction with #147552

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 20, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@jieyouxu jieyouxu self-assigned this May 20, 2026
@fallofpheonix
Copy link
Copy Markdown
Author

Thanks, that makes sense.

I investigated this further on my side as well. I checked an older revision (281c97c) and tests/debuginfo/path.rs still fails for me on Apple LLDB 2100, so it did not look like a recent regression in Rust itself.

path.rs was added for Path / PathBuf pretty printer support, and it appears to be the only debuginfo test currently using po.

The pretty printers still seem to work correctly through print; the failure comes from po falling back to p on Apple LLDB 2100.

If this is indeed related to #147552, I'm happy to adjust the approach or update the PR accordingly.

@workingjubilee
Copy link
Copy Markdown
Member

The actual root cause is simply that we do not test this version in CI. I believe we test LLDB 1703 now? See

@bors try jobs=aarch64-apple

Making the test more tolerant by making it accept virtually anything with the same prefix, when it previously tested for two different output formats, one significantly more verbose than the test checks for, does seem to defeat the purpose of having a test here.

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 21, 2026
Use print instead of po in debuginfo path test


try-job: aarch64-apple
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 21, 2026

☀️ Try build successful (CI)
Build commit: 7ca6154 (7ca61549aa9da0d8349ccec9e4569b85d307fb77, parent: b954122bbe6c4a244c511a9a168c6d5438d8f58f)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests/debuginfo/path.rs test failing on MacOS

6 participants