Add more tests for the `optimize` attribute by veluca93 · Pull Request #157297 · rust-lang/rust

veluca93 · 2026-06-02T09:42:39Z

Tracking issue: #54882
Stabilization PR: #157273

rustbot · 2026-06-02T09:42:44Z

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 17 candidates

jieyouxu

Thanks, a few more coverage nits
@rustbot author

View changes since this review

rustbot · 2026-06-02T10:02:43Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

veluca93 · 2026-06-02T20:38:14Z

@rustbot ready

jieyouxu

Thanks, looks good but needs a rebase.

View changes since this review

jieyouxu

@bors r+ rollup

View changes since this review

rust-bors · 2026-06-03T08:04:13Z

📌 Commit fba4788 has been approved by jieyouxu

It is now in the queue for this repository.

…eyouxu Add more tests for the `optimize` attribute Tracking issue: rust-lang#54882 Stabilization PR: rust-lang#157273

veluca93 · 2026-06-03T18:44:52Z

@rustbot ready

JonathanBrouwer · 2026-06-03T19:00:18Z

Note that #157332 hasn't merged yet, so we need to wait with approving this still. That pr conflicted with yet another pr and had to wait a rollup 😂

jieyouxu · 2026-06-04T01:05:38Z

@bors r+

rust-bors · 2026-06-04T01:05:41Z

📌 Commit e63c09f has been approved by jieyouxu

It is now in the queue for this repository.

…eyouxu Add more tests for the `optimize` attribute Tracking issue: rust-lang#54882 Stabilization PR: rust-lang#157273

jhpratt · 2026-06-04T01:49:28Z

@bors r-

#157403 (comment)

rust-bors · 2026-06-04T01:49:34Z

This pull request was unapproved.

This PR was contained in a rollup (#157403), which was unapproved.

View changes since this unapproval

rustbot · 2026-06-04T08:23:10Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

veluca93 · 2026-06-04T08:23:22Z

I see this keeps being accidentally hit by other changes :-)

@rustbot ready

jieyouxu · 2026-06-04T08:42:46Z

🙏
@bors r+

rust-bors · 2026-06-04T08:42:49Z

📌 Commit 1745325 has been approved by jieyouxu

It is now in the queue for this repository.

…uwer Rollup of 4 pull requests Successful merges: - #157297 (Add more tests for the `optimize` attribute) - #157377 (Add target checking to `#[register_tool]`) - #157138 (Add doc comment to `Vec::clone`) - #157400 (Add regression test for late-bound type param in nested `impl Trait`)

Rollup merge of #157297 - veluca93:more-optimize-tests, r=jieyouxu Add more tests for the `optimize` attribute Tracking issue: #54882 Stabilization PR: #157273

rustbot assigned dingxiangfei2009 Jun 2, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 2, 2026

veluca93 mentioned this pull request Jun 2, 2026

stabilize optimize attribute #157273

Open

jieyouxu reviewed Jun 2, 2026

View reviewed changes

Comment thread tests/ui/attributes/malformed-attrs.rs

Comment thread tests/ui/attributes/optimize.rs

Comment thread tests/ui/attributes/optimize.rs

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2026

jieyouxu reviewed Jun 2, 2026

View reviewed changes

Comment thread tests/ui/attributes/malformed-attrs.rs

jieyouxu self-assigned this Jun 2, 2026

This comment has been minimized.

Sign in to view

veluca93 force-pushed the more-optimize-tests branch from 534f1da to 14b4baf Compare June 2, 2026 20:37

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 2, 2026

veluca93 force-pushed the more-optimize-tests branch from 14b4baf to 1333de7 Compare June 2, 2026 21:26

This comment has been minimized.

Sign in to view

jieyouxu approved these changes Jun 3, 2026

View reviewed changes

veluca93 force-pushed the more-optimize-tests branch from 1333de7 to fba4788 Compare June 3, 2026 06:30

This comment has been minimized.

Sign in to view

jieyouxu approved these changes Jun 3, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2026

jieyouxu unassigned dingxiangfei2009 Jun 3, 2026

JonathanBrouwer mentioned this pull request Jun 3, 2026

Rollup of 9 pull requests #157372

Closed

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 3, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2026

jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 4, 2026

Rollup merge of rust-lang#157297 - veluca93:more-optimize-tests, r=ji…

3528b90

…eyouxu Add more tests for the `optimize` attribute Tracking issue: rust-lang#54882 Stabilization PR: rust-lang#157273

jhpratt mentioned this pull request Jun 4, 2026

Rollup of 3 pull requests #157403

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 4, 2026

Add more tests for the optimize attribute

1745325

veluca93 force-pushed the more-optimize-tests branch from e63c09f to 1745325 Compare June 4, 2026 08:23

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 4, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2026

JonathanBrouwer mentioned this pull request Jun 4, 2026

Rollup of 4 pull requests #157421

Merged

rust-bors Bot merged commit 411e9fc into rust-lang:main Jun 4, 2026
12 checks passed

rustbot added this to the 1.98.0 milestone Jun 4, 2026

rust-timer added a commit that referenced this pull request Jun 4, 2026

Unrolled build for #157297

9c625fc

Rollup merge of #157297 - veluca93:more-optimize-tests, r=jieyouxu Add more tests for the `optimize` attribute Tracking issue: #54882 Stabilization PR: #157273

Uh oh!

Conversation

veluca93 commented Jun 2, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 2, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Jun 2, 2026

Uh oh!

Uh oh!

This comment has been minimized.

veluca93 commented Jun 2, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Jun 3, 2026

Uh oh!

This comment has been minimized.

veluca93 commented Jun 3, 2026

Uh oh!

JonathanBrouwer commented Jun 3, 2026

Uh oh!

jieyouxu commented Jun 4, 2026

Uh oh!

rust-bors Bot commented Jun 4, 2026

Uh oh!

jhpratt commented Jun 4, 2026

Uh oh!

rust-bors Bot commented Jun 4, 2026

Uh oh!

rustbot commented Jun 4, 2026

Uh oh!

veluca93 commented Jun 4, 2026

Uh oh!

jieyouxu commented Jun 4, 2026

Uh oh!

rust-bors Bot commented Jun 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

veluca93 commented Jun 2, 2026 •

edited by rustbot

Loading

jieyouxu left a comment •

edited by rustbot

Loading

jieyouxu left a comment •

edited by rustbot

Loading

jieyouxu left a comment •

edited by rustbot

Loading