Skip to content

Suggest type next to visibility for const items#157382

Open
reddevilmidzy wants to merge 1 commit into
rust-lang:mainfrom
reddevilmidzy:pub-type-const
Open

Suggest type next to visibility for const items#157382
reddevilmidzy wants to merge 1 commit into
rust-lang:mainfrom
reddevilmidzy:pub-type-const

Conversation

@reddevilmidzy
Copy link
Copy Markdown
Member

resolve: #157368

Adjusts the type const suggestion to preserve visibility ordering, so pub const is suggested as pub type const instead of type pub const.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 3, 2026

HIR ty lowering was modified

cc @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 3, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 3, 2026

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

@petrochenkov
Copy link
Copy Markdown
Contributor

r? compiler

@rustbot rustbot assigned Kivooeo and unassigned petrochenkov Jun 3, 2026
@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Jun 3, 2026

Hey, thanks for a PR, I'm a bit busy this week. I will try to review within next 3 days

@rust-log-analyzer

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion reorders visibility incorrectly for type const items

5 participants