Silence llbc's output by default to prevent rustc's linker output warning#157399
Open
kulst wants to merge 1 commit into
Open
Silence llbc's output by default to prevent rustc's linker output warning#157399kulst wants to merge 1 commit into
kulst wants to merge 1 commit into
Conversation
…ning Make the linker quiet by default and add linker command line arguments for explicit verbosity control: - no flag: no tracing output is emitted during successful links - `-v`: emit informational linker diagnostics - `-vv`: emit tracing-level linker diagnostics Also adjust the tracing formatter to produce linker-style output by disabling ANSI color sequences and omitting timestamps, tracing levels, and tracing targets.
rustbot
added
the
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
L-linker_messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#153968 recently made visible that the llvm-bitcode-linker (llbc) always emits messages to stdout even when linking successfully. Additionally, these messages use ANSI escape sequences for coloring, which don't get rendered correctly.
This patch fixes both.
-vfor verbose and-vvfor very verbose, which can be added by using rustc's-Clink-arg=argument).cc: @kjetilkjeka
@rustbot label +L-linker_messages +O-NVPTX