Rollup of 5 pull requests by JonathanBrouwer · Pull Request #157433 · rust-lang/rust

JonathanBrouwer · 2026-06-04T13:33:27Z

Successful merges:

Record failed tests with --record, and rerun them with --rerun #154586 (Record failed tests with --record, and rerun them with --rerun)
delegation: split resolution and lowering #157296 (delegation: split resolution and lowering)
Fix a coroutine UI test which is missing #[coroutine] #156171 (Fix a coroutine UI test which is missing #[coroutine])
tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes #157249 (tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes)
rustc-dev-guide subtree update #157426 (rustc-dev-guide subtree update)

r? @ghost

Create a similar rollup

fix -s to -S in llvm tooling instructiongs

…0505-stage Fix name of first compiled stage, as stage0 is downloaded

Replace `rustc_session::parse::feature*` with ``rustc_session::errors::feature*`

Update dependencies to remove windows-targets dependency

Autodiff doc updates

autodiff: reference rustup installation support

This updates the rust-version file to a31c27a.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@a31c27a Filtered ref: rust-lang/rustc-dev-guide@66a2aa8 Upstream diff: rust-lang/rust@f2b291d...a31c27a This merge was created using https://github.com/rust-lang/josh-sync.

…c-pull Rustc pull update

Fix sample code for std::offload at usage.md

Clarify importance of `target-cpu` flag for offload

Added note about stage2 dependency in rustup toolchain linking.

Added a note about building tools and linked to tool tests section.

Add note on building tools in how-to-build-and-run.md

Add docs for non defining vs defining uses in opaque types

Co-authored-by: jyn <github@jyn.dev>

Update quickstart.md with stage2 note

…y789,jieyouxu Record failed tests with `--record`, and rerun them with `--rerun` This adds two parameters to `x test`: ## `--record` Writes a file, by default `build/failed-tests`, but this can be overwritten with ```toml [build] record_failed_tests_path = "somepath" ``` with a list of all tests that fail that run. ## `--rerun` Looks for the failed-tests file, parse it, and attempt to rerun only those tests. No cli-arguments are necessary, i.e. ``` x test tests/ui --record x test --rerun ``` Will run all failed uitests. No need to pass tests/ui to the rerun invocation. The last commit is a little awkward, but I think it's the best way to make it so that we *first* run all tests that have to be rerun, and *then* rerun tests passed through the cli. This makes it so: ``` x test tests/ui --rerun ``` will *first* rerun failed tests, some of which may be uitests, if any fail it quits and reports failed tests, but if all pass it will run all normally passed tests. In other words, only if all previously-failed tests pass on the rerun, we then also run uitests. Without the last commit, this would instead just run all uitests, since the failed tests form a subset of all uitests. I think that's less useful.

@petrochenkov

…ve, r=petrochenkov delegation: split resolution and lowering This PR splits delegation's AST -> HIR lowering and its resolution. Now we resolve all delegations and then lower them. This should have benefits: - ~For rust-lang#156798, where it will be convenient to insert diagnostics about specifying target expressions for glob reuses of only static functions (the `delegations_resolutions` map will contain information whether to lower or delete target expression)~ - For rust-lang#155337 and delegations to inherent methods resolution, as from what I tested up until now we should resolve them in iterative manner before AST -> HIR lowering. Part of rust-lang#118212. r? @petrochenkov

…llot Fix a coroutine UI test which is missing `#[coroutine]` This looks like a typo, although the test now produces a different error to the other errors in the file. I also fixed some comment typos in tests, happy to drop that commit if you don't want to review it.

@nagisa

…u32, r=nikic tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes The LLVM backend now emits `noundef zeroext` on `i8` return values and `noundef` on `i8` parameters. Update the FileCheck pattern to match. r? @nagisa

@ghost

rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@e99720b. Created using https://github.com/rust-lang/josh-sync. r? @ghost

JonathanBrouwer · 2026-06-04T13:33:40Z

@bors r+ rollup=never p=5

rust-bors · 2026-06-04T13:33:42Z

📌 Commit 798684a has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-bors · 2026-06-04T17:24:54Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 19m 12s
Pushing b3f7e32 to main...

rust-timer · 2026-06-04T17:26:27Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#154586	Record failed tests with `--record`, and rerun them with `-…	`d68e178610068f27d43be17765f820774aa4cfbb` (link)
#156171	Fix a coroutine UI test which is missing `#[coroutine]`	`6fce9b3ddb035a564324cab3b00299af979fdad8` (link)
#157249	tests: codegen-llvm: Update bpf-alu32 with the new LLVM att…	`821c6d868bd44ee50ead05ad45c636d05f3fe5fb` (link)
#157296	delegation: split resolution and lowering	`5d52d85fa992ee42a71334ebdbb2fbeed248ee24` (link)
#157426	rustc-dev-guide subtree update	`918bed642909ee11d66b455dab29cf9fe278cc3e` (link)

previous master: 9ae765da47

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-06-04T17:28:20Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9ae765d (parent) -> b3f7e32 (this PR)

Test differences

Show 68 test diffs

Stage 1

[codegen] tests/codegen-llvm/bpf-alu32.rs: ignore (only executed when the architecture is bpf) -> pass (J1)

Stage 2

[codegen] tests/codegen-llvm/bpf-alu32.rs: ignore (only executed when the architecture is bpf) -> pass (J0)

Additionally, 66 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b3f7e3204640c7458c9f5096f3e9c5ad9971a51c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-gnu-gcc-core-tests: 9m 52s -> 14m 36s (+47.8%)
x86_64-msvc-ext1: 1h 42m -> 2h 18m (+34.7%)
dist-x86_64-illumos: 1h 24m -> 1h 51m (+32.3%)
x86_64-gnu-aux: 1h 48m -> 2h 18m (+27.9%)
x86_64-gnu-llvm-21-1: 43m 19s -> 54m 54s (+26.7%)
x86_64-gnu-nopt: 2h 31m -> 1h 52m (-25.9%)
dist-i686-mingw: 2h 6m -> 2h 37m (+24.8%)
dist-x86_64-apple: 2h 8m -> 2h 38m (+22.7%)
dist-x86_64-mingw: 2h 3m -> 2h 30m (+21.8%)
dist-powerpc64-linux-musl: 1h 16m -> 1h 32m (+21.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-06-04T18:06:37Z

Finished benchmarking commit (b3f7e32): comparison URL.

Overall result: ❌ regressions - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	1
Regressions ❌ (secondary)	0.4%	[0.4%, 0.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[0.7%, 0.7%]	1

Max RSS (memory usage)

Results (primary 6.5%, secondary 2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	6.5%	[6.5%, 6.5%]	1
Regressions ❌ (secondary)	5.9%	[5.7%, 6.2%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.0%	[-5.0%, -5.0%]	1
All ❌✅ (primary)	6.5%	[6.5%, 6.5%]	1

Cycles

Results (secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.1%, 2.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.8%	[-11.4%, -1.9%]	4
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	4
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	4

Bootstrap: 515.26s -> 512.944s (-0.45%)
Artifact size: 400.73 MiB -> 398.65 MiB (-0.52%)

JonathanBrouwer · 2026-06-04T18:17:16Z

@rustbot label: +perf-regression-triaged
Noise

xonx4l and others added 30 commits January 21, 2026 13:07

add docs for non defining vs defining uses

14026bf

Fix name of first compiled stage, as stage0 is downloaded

8d57ec1

fix -s to -S in llvm tooling instructiongs

7e14c4e

Merge pull request rust-lang#2868 from rust-lang/autodiff-dbg-typo

9d0faee

fix -s to -S in llvm tooling instructiongs

Merge pull request rust-lang/rustc-dev-guide#2864 from cammeresi/2026…

91d0f9f

…0505-stage Fix name of first compiled stage, as stage0 is downloaded

move feature* methods from parse mod to errors mod

aa42817

Merge pull request rust-lang#2869 from rust-lang/mv-feature-methods

f64009b

Replace `rustc_session::parse::feature*` with ``rustc_session::errors::feature*`

Update dependencies to remove windows-targets dependency

420c26e

Merge pull request rust-lang#2870 from bjorn3/windows_sys_0_61

4b53eb5

Update dependencies to remove windows-targets dependency

update std::autodiff link to point to nighlty autodiff docs

b6f6ba8

add short motivation

fef299d

Merge pull request rust-lang#2871 from rust-lang/autodiff-doc-updates

78c4ea6

Autodiff doc updates

reference rustup installation support

51ef55a

Merge pull request rust-lang#2873 from rust-lang/update-autodiff-rustup

f205084

autodiff: reference rustup installation support

Fix sample code for std::offload at usage.md

792f73c

Prepare for merging from rust-lang/rust

e2f2990

This updates the rust-version file to a31c27a.

Merge pull request rust-lang/rustc-dev-guide#2875 from rust-lang/rust…

45aa7c9

…c-pull Rustc pull update

Merge pull request rust-lang#2874 from sgasho/main

19da8b2

Fix sample code for std::offload at usage.md

Clarify importance of target-cpu flag for offload

4fe70e6

fix: use div with class warning

40f27e8

Merge pull request rust-lang#2876 from xkevio/patch-2

38e65c7

Clarify importance of `target-cpu` flag for offload

Update quickstart.md with stage2 note

76c3344

Added note about stage2 dependency in rustup toolchain linking.

Add note on building tools in how-to-build-and-run.md

df80304

Added a note about building tools and linked to tool tests section.

Update how-to-build-and-run.md

8a0eb89

Merge pull request rust-lang#2878 from Its-Just-Nans/patch-2

43d3597

Add note on building tools in how-to-build-and-run.md

Merge pull request rust-lang#2736 from xonx4l/non-def-vs-def

ae93d51

Add docs for non defining vs defining uses in opaque types

Update quickstart.md

7cfb791

Update src/building/quickstart.md

1cd2388

Co-authored-by: jyn <github@jyn.dev>

Merge pull request rust-lang#2877 from Its-Just-Nans/patch-1

b16d7eb

Update quickstart.md with stage2 note

teor2345 and others added 6 commits June 4, 2026 15:10

Fix some comment typos in tests

6311909

Rollup merge of rust-lang#157426 - tshepang:rdg-sync, r=tshepang

798684a

rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@e99720b. Created using https://github.com/rust-lang/josh-sync. r? @ghost

rust-bors Bot added the rollup A PR which is a rollup label Jun 4, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 4, 2026

rust-bors Bot merged commit b3f7e32 into rust-lang:main Jun 4, 2026
13 checks passed

rustbot added this to the 1.98.0 milestone Jun 4, 2026

This was referenced Jun 4, 2026

delegation: do not always generate first argument #156798

Open

Revert "LLVM 23: Run AssignGUIDPass in some places" #157365

Draft

rustbot added the perf-regression Performance regression. label Jun 4, 2026

rustbot added the perf-regression-triaged The performance regression has been triaged. label Jun 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests#157433

Rollup of 5 pull requests#157433
rust-bors[bot] merged 67 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-d3I87zR

JonathanBrouwer commented Jun 4, 2026

Uh oh!

JonathanBrouwer commented Jun 4, 2026

Uh oh!

rust-bors Bot commented Jun 4, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 4, 2026

Uh oh!

Uh oh!

rust-timer commented Jun 4, 2026

Uh oh!

github-actions Bot commented Jun 4, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Jun 4, 2026

Uh oh!

JonathanBrouwer commented Jun 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Uh oh!

Conversation

JonathanBrouwer commented Jun 4, 2026

Uh oh!

JonathanBrouwer commented Jun 4, 2026

Uh oh!

rust-bors Bot commented Jun 4, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 4, 2026

Uh oh!

Uh oh!

rust-timer commented Jun 4, 2026

Uh oh!

github-actions Bot commented Jun 4, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jun 4, 2026

Overall result: ❌ regressions - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

JonathanBrouwer commented Jun 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants