Skip to content

Ip address basic support#8

Open
yonatan-linik wants to merge 1 commit into
rust-netlink:mainfrom
yonatan-linik:ip-address-basic-support
Open

Ip address basic support#8
yonatan-linik wants to merge 1 commit into
rust-netlink:mainfrom
yonatan-linik:ip-address-basic-support

Conversation

@yonatan-linik
Copy link
Copy Markdown
Contributor

@yonatan-linik yonatan-linik commented Nov 29, 2025

No description provided.

@cathay4t
Copy link
Copy Markdown
Member

cathay4t commented May 1, 2026

@yonatan-linik Do you still have interest on continue the work here?

@yonatan-linik
Copy link
Copy Markdown
Contributor Author

@yonatan-linik Do you still have interest on continue the work here?

Yes, I waited for the bond support to be merged 🙏

@yonatan-linik yonatan-linik force-pushed the ip-address-basic-support branch 2 times, most recently from 914c169 to f702ea3 Compare May 2, 2026 18:15
@yonatan-linik yonatan-linik marked this pull request as ready for review May 2, 2026 18:15
@yonatan-linik
Copy link
Copy Markdown
Contributor Author

I removed the flags for controller and port, because it caused local test runs to fail.
I saw the following comment, but I am not sure how else I can get around these failures:

// Compatible with iproute2, but we still append `PORT` after
// iproute2 flags.
Screenshot 2026-05-02 182749

@cathay4t
Copy link
Copy Markdown
Member

cathay4t commented May 4, 2026

Let's remove this controller/port stuff now and focus on full compatible.

We can always add iproute-rs --no-compact to introduce fancy own stuff.

@yonatan-linik yonatan-linik force-pushed the ip-address-basic-support branch from f702ea3 to c24f6f2 Compare May 5, 2026 14:45
@yonatan-linik
Copy link
Copy Markdown
Contributor Author

@cathay4t Should be ready for review

@cathay4t
Copy link
Copy Markdown
Member

cathay4t commented May 14, 2026

The patch looks ok, but let me extract some code to netlink-packet-route for Display trait implementation.

This repo should not hold such codes.

@cathay4t
Copy link
Copy Markdown
Member

I have created rust-netlink/netlink-packet-route#256

We only need to handle [RT_SCOPE_UNIVERSE] = "global" here for display.

@yonatan-linik yonatan-linik force-pushed the ip-address-basic-support branch from c24f6f2 to d1d3e69 Compare May 14, 2026 15:12
@yonatan-linik yonatan-linik force-pushed the ip-address-basic-support branch from d1d3e69 to 6500e7d Compare May 14, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants