SkewNormal distribution implementation#1174
Merged
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1149.
Implements the Skew Normal distribution.
Most notably I had to add a dev-dependency to include distribution tests similar to #1121.
Adding the test was suggested by @dhardy.
There was a brief discussion about adding dev-dependencies for special functions with @vks in here. We talked about the crate
spfunc, since it is a pure Rust implementation of special functions. It is still a very young crate and the functionerfis still not there. Therefore, I chose to addstatrsas it is a close companion of this crate, which is also pure Rust.