Skip to content

Add U32string_view wrapper - #71

Open
Jennycj wants to merge 7 commits into
rustfoundation:mainfrom
Jennycj:u32string-view-overloads
Open

Jennycj wants to merge 7 commits into
rustfoundation:mainfrom
Jennycj:u32string-view-overloads

Conversation

@Jennycj

@Jennycj Jennycj commented Nov 4, 2026 •

Copy link
Copy Markdown

Added a wrapper for std::U32string_view with 4 overloads including constructor, and methods: compare, find and startwith
Implements #43

  1. Write Rust wrappers for that U32string_view, for 3-5 different overloaded method names:

    • Create a new file named after your type in overloading-macros/cpp-overload-test/src/stdcpp
    • Wrap constructors first, writing tests to make sure the correct constructor is called
    • Explain any potential compatibility issues in a Limitations doc section
    • Explain usability issues in an Ergonomics doc section
    • Check that you have implemented all the overloads for each method name, or documented why you can't
    • Push your changes and wait for a review
  2. Add a separate example with some failing overloads

    • Create a new file named after your type in overloading-macros/cpp-overload-test/examples
    • [] Wrap accessor/modifier methods
    • Explain how they fail in an Incompatibilities doc section
    • Explain how the overload failures could be resolved in a Workarounds doc section
    • Optional: If there's a C++ feature with no equivalent in Rust, explain that in an Inexpressible Overloads doc section
    • Push your changes and wait for a review
  3. Update the overload macro compatibility table Markdown doc

    • If you haven't checked some kinds of overloads, put a ?in those squares
    • Push your changes and wait for a review

@teor2345 teor2345 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for this PR!

Please submit steps 2 & 3 immediately, without waiting for reviews. Outreachy applications are due on Monday 9 November, and I want you to be able to get one or two reviews of everything in your PR.

Please remember to submit an Outreachy application! You can include any Rust work during the application period.

I added a merge commit, feel free to keep it or force-push over it.

@Jennycj

Jennycj commented Nov 5, 2026

Copy link
Copy Markdown
Author

Hi, thank you for this PR!

Please submit steps 2 & 3 immediately, without waiting for reviews. Outreachy applications are due on Monday 9 November, and I want you to be able to get one or two reviews of everything in your PR.

Please remember to submit an Outreachy application! You can include any Rust work during the application period.

I added a merge commit, feel free to keep it or force-push over it.

Thank you @teor2345 for the reminder!
I will keep the merge commit and send in 2 & 3 as soon as possible

@teor2345

teor2345 commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Just reminding you that the Outreachy final application deadline is this Monday 9 November. You can include any Rust PR or ticket work you've done, it doesn't have to be merged (or reviewed) yet.

Please submit a final application on the Outreachy website before Monday. The exact deadline is 4pm UTC, but it is better to submit early. You can edit your submitted application up until the deadline (and you can keep working on PRs after the deadline).

@Jennycj

Jennycj commented Nov 7, 2026

Copy link
Copy Markdown
Author

Just reminding you that the Outreachy final application deadline is this Monday 9 November. You can include any Rust PR or ticket work you've done, it doesn't have to be merged (or reviewed) yet.

Please submit a final application on the Outreachy website before Monday. The exact deadline is 4pm UTC, but it is better to submit early. You can edit your submitted application up until the deadline (and you can keep working on PRs after the deadline).

I have now added steps 2 & 3 for this PR and submitted the final application.
Thanks @teor2345 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants