Add advisory for solana_rbpf: OOB pointer arithmetic in invoke_function#2921
Open
DiuDiu777 wants to merge 1 commit into
Open
Add advisory for solana_rbpf: OOB pointer arithmetic in invoke_function#2921DiuDiu777 wants to merge 1 commit into
invoke_function#2921DiuDiu777 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected crate(s)
solana_rbpf(362,603 recent downloads per crates.io; 4,761,947 total downloads)Links to upstream issue(s) or PR(s)
The upstream repository is archived, so I cannot report this through the normal upstream issue tracker.
Severity
Informational soundness issue. Safe Rust code can construct an
EbpfVmand call the safe methodEbpfVm::invoke_function, which performs out-of-bounds pointer arithmetic internally.The affected implementation casts
selfto*mut u64and applies a randomized offset fromget_runtime_environment_key()usingptr::offset. This can move the pointer outside the allocation containing theEbpfVm, causing undefined behavior before the supplied builtin function is invoked. Miri reports an in-bounds pointer arithmetic violation. Nounsafecode is required from the caller.Checklist
RUSTSEC-0000-0000as the IDdatefield is set to the public disclosure date