commit for associating the FPHXBCO and INTT_long_BCO information with TrkrHit

[ChengWeiShih]

comment: The commit is to associate the INTT timing information with the TrkrHit, which is very important for the study of the INTT carried-over-hit issue in streaming.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work for users)
• Requiring change in macros repository (Please provide links to the macros pull request in the last section)
• I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

comment:
The modification doesn't touch the hit_set_key structure. But change the TrkrHit data class. The following four are modified.
trackbase/TrkrHit.h
trackbase/TrkrHitv1.cc
trackbase/TrkrHitv1.h
trackbase/TrkrHitv2.cc
trackbase/TrkrHitv2.h

And intt/InttCombinedRawDataDecoder.cc is updated to assign the INTT_FPHX_BCO and INTT_long_BCO to Trkrhit.

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ea46e56b-bc79-4b75-93f6-3bd00f652697

📥 Commits

Reviewing files that changed from the base of the PR and between 82714a4 and b63099b.

📒 Files selected for processing (6)

• offline/packages/intt/InttCombinedRawDataDecoder.cc
• offline/packages/trackbase/TrkrHit.h
• offline/packages/trackbase/TrkrHitv1.cc
• offline/packages/trackbase/TrkrHitv1.h
• offline/packages/trackbase/TrkrHitv2.cc
• offline/packages/trackbase/TrkrHitv2.h

---

📝 Walkthrough

Walkthrough

This PR extends track hit data structures across the sPHENIX tracking detector software to include frontend bunch counter (FPHX_BCO) and bunch counter (BCO) timing fields. Virtual accessor methods are added to the base TrkrHit class, implemented in concrete TrkrHitv1 and TrkrHitv2 classes with accompanying storage, while the INTT decoder and copy operations are updated to populate and propagate these fields.

Changes

Cohort / File(s)	Summary
Base TrkrHit Interface offline/packages/trackbase/TrkrHit.h	Added virtual method declarations for setFPHXBCO() / getFPHXBCO() (uint16_t) and setBCO() / getBCO() (uint64_t); base implementations are no-op setters and zero-returning getters.
TrkrHitv1 Implementation offline/packages/trackbase/TrkrHitv1.h, TrkrHitv1.cc	Added protected data members m_fphx_bco and m_bco; implemented FPHX_BCO and BCO accessor overrides; updated CopyFrom() to propagate these fields; incremented ROOT ClassDefOverride version from 1 to 3.
TrkrHitv2 Implementation offline/packages/trackbase/TrkrHitv2.h, TrkrHitv2.cc	Added protected data members m_fphx_bco and m_bco; implemented FPHX_BCO and BCO accessor overrides; updated CopyFrom() to propagate these fields; incremented ROOT ClassDefOverride version from 1 to 3; identify() now outputs timing fields.
INTT Decoder Integration offline/packages/intt/InttCombinedRawDataDecoder.cc	During hit creation in process_event(), now populates FPHX_BCO from intthit->get_FPHX_BCO() and BCO from intthit->get_bco() on newly allocated TrkrHitv2 objects.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sphenix-jenkins-ci]

Build & test report

Report for commit b63099b4224fd902b2f2004c599ecc63a3c67792:

• builds and tests overall are FAILURE.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, 📊 trends
    • 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 27.45 / 72, and combined p-Value = 1
    • 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.6183 / 72, and combined p-Value = 0.998442
    • 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.4559 / 42, and combined p-Value = 1
    • 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 14.2531 / 42, and combined p-Value = 0.999981
  • Tracking QA with Distortions: build is SUCCESS, 📊 trends
    • 📊 QA-distortions
  • Tracking QA at low occupancy: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-vertexing : combined Chi2/nDoF = 178.132 / 112, and combined p-Value = 7.06654e-05
  • Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = 5.52413 / 50, and combined p-Value = 1
    • 📊 QA-vertexing : combined Chi2/nDoF = 445.367 / 112, and combined p-Value = 2.69957e-41
  • Tracking QA from run2pp 53877: build is SUCCESS, 📊 trends
    • 📊 QA-intt : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
    • 📊 QA-micromegas : combined Chi2/nDoF = -0 / 6, and combined p-Value = 1
    • 📊 QA-mvtx : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
    • 📊 QA-siliconseeds : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-tpc : combined Chi2/nDoF = -0 / 48, and combined p-Value = 1
    • 📊 QA-tpcseeds : combined Chi2/nDoF = 0.00909133 / 28, and combined p-Value = 1
    • 📊 QA-trackfit : combined Chi2/nDoF = -0 / 32, and combined p-Value = 1
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
• clang-tidy is FAILURE, 📊clang-tidy report (full)/(new)
• cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration
           

[osbornjd]

This will break our DST readback completely because it adds a new member object to the existing vX.h classes. What you need to do is create an entirely new TrkrHitv3.h with the new member variable, and create v3 in the decoder class

[ChengWeiShih]

@osbornjd I see, OK. Let me do it accordingly. Thank you for letting me know.

[sphenix-jenkins-ci]

Build & test report

Report for commit 2a198c1bf6a6a5187e592218d750191e768ac5fc:

• builds and tests overall are FAILURE.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, 📊 trends
    • 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 27.45 / 72, and combined p-Value = 1
    • 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.6183 / 72, and combined p-Value = 0.998442
    • 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.4559 / 42, and combined p-Value = 1
    • 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 14.2531 / 42, and combined p-Value = 0.999981
  • Tracking QA with Distortions: build is SUCCESS, 📊 trends
    • 📊 QA-distortions
  • Tracking QA at low occupancy: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-vertexing : combined Chi2/nDoF = 178.132 / 112, and combined p-Value = 7.06654e-05
  • Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = 2.23969e-06 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = 5.52413 / 50, and combined p-Value = 1
    • 📊 QA-vertexing : combined Chi2/nDoF = 445.367 / 112, and combined p-Value = 2.69957e-41
  • Tracking QA from run2pp 53877: build is SUCCESS, 📊 trends
    • 📊 QA-intt : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
    • 📊 QA-micromegas : combined Chi2/nDoF = -0 / 6, and combined p-Value = 1
    • 📊 QA-mvtx : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
    • 📊 QA-siliconseeds : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-tpc : combined Chi2/nDoF = 12.8795 / 48, and combined p-Value = 1
    • 📊 QA-tpcseeds : combined Chi2/nDoF = 0.0664795 / 28, and combined p-Value = 1
    • 📊 QA-trackfit : combined Chi2/nDoF = 0.000776367 / 32, and combined p-Value = 1
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
• clang-tidy is FAILURE, 📊clang-tidy report (full)/(new)
• cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration