Skip to content

Widget load improvements#479

Merged
Sam Beveridge (00salmon) merged 38 commits intomasterfrom
widget-load
Apr 1, 2026
Merged

Widget load improvements#479
Sam Beveridge (00salmon) merged 38 commits intomasterfrom
widget-load

Conversation

@00salmon
Copy link
Copy Markdown
Contributor

@00salmon Sam Beveridge (00salmon) commented Feb 20, 2026 •
edited by zachharrison
Loading

Description of the change

General improvement to Mint components loading style and performance.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

Copilot AI review requested due to automatic review settings February 20, 2026 21:05
Copilot AI reviewed Feb 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements widget load improvements through the introduction of a custom skeleton component and updates to the tax and cash dashboard to support additional payout hold states.

Changes:

  • Introduced a new customizable sqm-skeleton component to replace sl-skeleton throughout the codebase
  • Added support for additional payout hold states (payment on hold, beneficiary name issues, withdrawal settings invalid, payment returned)
  • Enhanced sqm-header-logo component to support text-based logos as a fallback to images

Reviewed changes

Copilot reviewed 73 out of 75 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/mint-components/src/components/sqm-skeleton/sqm-skeleton.tsx New skeleton component with customizable width, height, and theming support
packages/mint-components/src/global/styles.ts Added CSS variables for skeleton background and animation colors
packages/mint-components/src/components/tax-and-cash/sqm-payout-status-alert/usePayoutStatus.ts Added new payout status types and logic for handling additional hold reasons
packages/mint-components/src/components/tax-and-cash/sqm-tax-and-cash/sqm-tax-and-cash.tsx Updated button labels for consistency and added new alert message properties
packages/mint-components/src/components/sqm-form-message/sqm-form-message.tsx Added loading state support using the new skeleton component
packages/mint-components/src/components/sqm-header-logo/sqm-header-logo.tsx Added text-based logo support with customizable size and color
packages/mint-components/CHANGELOG.md Documents changes to payout alert copy and header logo functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 20, 2026 21:12
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 20, 2026
View reviewed changes
Copilot AI reviewed Feb 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 81 out of 83 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 27, 2026 23:49
Copilot AI review requested due to automatic review settings March 30, 2026 18:37
Copilot AI reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 105 out of 107 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 30, 2026 23:10
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 30, 2026
View reviewed changes
Copilot AI reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 111 out of 114 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 111 out of 114 changed files in this pull request and generated 4 comments.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 31, 2026 22:02
Copilot AI reviewed Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 112 out of 115 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings April 1, 2026 18:14
Copilot AI reviewed Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 112 out of 115 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@00salmon Sam Beveridge (00salmon) merged commit 9e55279 into master Apr 1, 2026
12 of 14 checks passed
@00salmon Sam Beveridge (00salmon) deleted the widget-load branch April 1, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@zachharrison Zach Harrison (zachharrison) zachharrison approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@00salmon @zachharrison @github-advanced-security @noahwc