Mint/Update Tax Dashboard Tax Section by AndiLuo · Pull Request #488 · saasquatch/program-tools

AndiLuo · 2026-03-25T22:52:02Z

Modified tax dashboard handling when User was previously required to submit a tax form, submitted it, but may/may not needs to have one.

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation or Development tools (readme, specs, tests, code formatting)

Links

Jira issue number: (PUT IT HERE)
Process.st launch checklist: (PUT IT HERE)

Checklists

Development

Prettier was run (if applicable)
The behaviour changes in the pull request are covered by specs
All tests related to the changed code pass in development

Paperwork

This pull request has a descriptive title and information useful to a reviewer
This pull request has a Jira number
This pull request has a Process.st launch checklist

Code review

Changes have been reviewed by at least one other engineer
Security impacts of this change have been considered

…itted form but no longer required

Copilot

Pull request overview

Updates the Mint tax & cash dashboard to display appropriate copy when a user previously submitted a tax form but is no longer required to submit one.

Changes:

Added a new configurable text prop for the “previously submitted but not required” tax-document state.
Rendered a new tax-documents UI block for the noFormNeeded && status === "ACTIVE" scenario.
Updated docs/types and added a Storybook story for the new state; bumped mint-components version.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
packages/mint-components/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard.tsx	Adds new Stencil `@Prop` for the new tax-documents description text.
packages/mint-components/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard-view.tsx	Adds a new conditional tax section rendering for `noFormNeeded` + `ACTIVE` status and wires in the new text.
packages/mint-components/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/readme.md	Documents the new component property/attribute.
packages/mint-components/src/components/tax-and-cash/TaxForm.stories.tsx	Adds a Storybook scenario for the new UI state.
packages/mint-components/src/components.d.ts	Updates generated typings to include the new component prop.
packages/mint-components/package.json	Version bump to `2.1.5-0`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...s/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard-view.tsx

packages/mint-components/src/components/tax-and-cash/TaxForm.stories.tsx

...s/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard-view.tsx

…atus for the users submitted tax document. Added spec

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

packages/mint-components/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard-view.tsx:1160

!!states.status will also be true for tax document status "NEW" (see TaxDocumentStatus), but statusMap doesn't define a rendering for "NEW". With this change, users in "NEW" state can end up seeing an empty status area (and the “Submit new tax form” button, since only "NOT_VERIFIED" is excluded). Add explicit handling for "NEW" (e.g., treat it like "NOT_VERIFIED") and ensure the new-form button logic matches that state.

                        <span class={sheet.classes.StatusAlert}>
                          {statusMap[states.status]}
                        </span>
                      </div>
                    </span>
                    {(!states.noFormNeeded || !!states.status) &&
                      states.status !== "NOT_VERIFIED" && (
                        <sl-button
                          disabled={states.disabled || states.loading}
                          onClick={callbacks.onClick}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...s/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard-view.tsx

...ts/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard.feature

...s/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard-view.tsx

Zach Harrison (zachharrison) · 2026-03-27T17:34:20Z

packages/mint-components/package.json

  "name": "@saasquatch/mint-components",
  "title": "Mint Components",
-  "version": "2.1.4",
+  "version": "2.1.5-1",


This needs to be set to a stable version number before we approve and merge this PR.

…te specs

…s and specs

Copilot

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...onents/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard.tsx

...s/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard-view.tsx

...ts/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard.feature

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...s/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard-view.tsx

Copilot · 2026-03-31T19:03:39Z

...s/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard-view.tsx

          {intl.formatMessage(
            {
              id: `badgeTextSubmittedOn`,
              defaultMessage:
-                states.documentType === "W9"
+                states.documentType === "W9" || !states.documentType
                  ? text.badgeTextSubmittedOn
                  : text.badgeTextSubmittedOnW8,


statusMap.ACTIVE now treats a missing states.documentType as W-9 (states.documentType === "W9" || !states.documentType), which can produce incorrect copy for users who previously submitted a W-8 but no longer have a required document type (the hook sets documentType from requiredTaxDocumentType, which becomes null). If the intent is to reflect the submitted form type, consider basing this choice on the submitted document type (e.g., currentTaxDocument.type exposed in state) rather than defaulting to W-9 when documentType is absent.

This is an edgecase because if the user submitted a W8 before and they get ported over to CASH_ONLY_DEFER_W9 tax setting, the requiredTaxDocumentType will equal null and the document type will not be available due to comply-exchange.

TLDR we want to display the W9 submittedOn text when requiredTaxDocumentType === null

packages/mint-components/src/components/tax-and-cash/TaxForm.stories.tsx

…date

Copilot

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

packages/mint-components/src/components/tax-and-cash/TaxForm.stories.tsx:1091

In this story, noFormNeeded is set to true while documentType is set to "W9". In the real hook (useTaxAndCashDashboard), noFormNeeded is derived from !documentType, so this combination is not representable and can make the story misleading. Consider either setting noFormNeeded: false or setting documentType/documentTypeString to undefined/"" to reflect the intended scenario.

        states: {
          veriffLoading: false,
          noFormNeeded: true,
          canEditPayoutInfo: true,
          status: "INACTIVE",
          documentType: "W9",
          documentTypeString: taxTypeToName("W9"),

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-31T23:46:48Z

...onents/src/components/tax-and-cash/sqm-tax-and-cash-dashboard/sqm-tax-and-cash-dashboard.tsx

      },
    },
    props.demoData || props.stateController || {},
-    { arrayMerge: (_, a) => a }
+    { arrayMerge: (_, a) => a },
  );


In useDemoTaxAndCashDashboard, the second deepmerge argument uses props.stateController directly, but stateController is a JSON string (defaulting to "{}"). Passing a string into deepmerge can override the merged object (or break merging), which makes demo/state-controller-driven rendering unreliable. Parse stateController into an object (e.g., via the existing parseStates pattern used in other demo hooks) before merging, and then merge props.demoData/parsed state consistently.

Added conditional rendering for tax section when user previously subm…

b2fea8b

…itted form but no longer required

Copilot AI review requested due to automatic review settings March 25, 2026 22:52

Copilot started reviewing on behalf of AndiLuo March 25, 2026 22:52 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

AndiLuo requested review from Derek Siemens (DerekSiemens), Noah Clarke (noahwc) and Zach Harrison (zachharrison) March 26, 2026 16:43

AndiLuo added 2 commits March 26, 2026 10:06

Update tax section conditional to display tax section if there's a st…

fd3dc73

…atus for the users submitted tax document. Added spec

Updated spec

c3f0765

Copilot AI review requested due to automatic review settings March 26, 2026 17:35

Copilot started reviewing on behalf of AndiLuo March 26, 2026 17:35 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

Zach Harrison (zachharrison) requested changes Mar 27, 2026

View reviewed changes

AndiLuo added 2 commits March 30, 2026 09:45

Add general Tax form header when there's no requiredTaxFormType. Upda…

2e73dec

…te specs

Fix INACTIVE tax form banner having legacy styles. Update some storie…

82e592f

…s and specs

Copilot AI review requested due to automatic review settings March 31, 2026 00:14

Copilot started reviewing on behalf of AndiLuo March 31, 2026 00:14 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

AndiLuo added 2 commits March 30, 2026 17:33

Update copy when no documentTypeString is present and add story

8322a65

Update copy and fix stories

d69ce39

Copilot AI review requested due to automatic review settings March 31, 2026 18:46

Copilot started reviewing on behalf of AndiLuo March 31, 2026 18:47 View session

Noah Clarke (noahwc) previously approved these changes Mar 31, 2026

View reviewed changes

Copilot AI reviewed Mar 31, 2026

View reviewed changes

AndiLuo added 2 commits March 31, 2026 13:18

Merge remote-tracking branch 'origin/master' into dashboard-tax-ui-up…

f0cb1fb

…date

Release stable version 2.1.6 and added changelog

17eb26b

Copilot AI review requested due to automatic review settings March 31, 2026 23:33

AndiLuo dismissed Noah Clarke (noahwc)’s stale review via 17eb26b March 31, 2026 23:33

Copilot started reviewing on behalf of AndiLuo March 31, 2026 23:34 View session

Zach Harrison (zachharrison) approved these changes Mar 31, 2026

View reviewed changes

Copilot AI reviewed Mar 31, 2026

View reviewed changes

AndiLuo merged commit 2f6b879 into master Mar 31, 2026
16 of 18 checks passed

AndiLuo deleted the dashboard-tax-ui-update branch March 31, 2026 23:57

Conversation

AndiLuo commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Links

Checklists

Development

Paperwork

Code review

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Zach Harrison (zachharrison) Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

AndiLuo Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

AndiLuo commented Mar 25, 2026 •

edited

Loading

AndiLuo Mar 31, 2026 •

edited

Loading