Skip to content

Fix Windows 3.14 pyexpat/elementtree duplicate-symbol link failure #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwoz merged 2 commits into from
Oct 30, 2026
Merged

Fix Windows 3.14 pyexpat/elementtree duplicate-symbol link failure #339

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6f0efb
Skip xcs.c include when CPython already compiles it
dwoz Oct 24, 2026
bffbaa1
Collapse vcxproj_compiles_xcs onto one line for ruff-format
dwoz Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions relenv/build/windows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,11 +447,16 @@ def update_expat(dirs: Dirs, env: EnvMapping) -> None:
f.write('#if defined(HAVE_ARC4RANDOM)\n#include "random_arc4random.c"\n#endif\n')
f.write('#if !defined(_WIN32) && defined(XML_DEV_URANDOM)\n#include "random_dev_urandom.c"\n#endif\n')
# expat >= 2.9.0 moved xcslen/xcscmp/xcsncmp into a separate TU
# (xcs.c). Python's build system only compiles xmlparse.c,
# xmlrole.c, and xmltok.c, so pull xcs.c into xmlparse.c's TU to
# avoid undefined-reference failures when linking pyexpat.
# (xcs.c). On Python versions whose PCbuild/pyexpat.vcxproj does
# not already compile xcs.c (3.10-3.13), pull it into xmlparse.c's
# TU so pyexpat links. On 3.14+ the vcxproj already lists xcs.c as
# a ClCompile entry — including it here would produce duplicate
# symbols at link time.
if (expat_dir / "xcs.c").exists():
f.write('#include "xcs.c"\n')
pyexpat_vcxproj = dirs.source / "PCbuild" / "pyexpat.vcxproj"
vcxproj_compiles_xcs = pyexpat_vcxproj.exists() and "expat\\xcs.c" in pyexpat_vcxproj.read_text()
if not vcxproj_compiles_xcs:
f.write('#include "xcs.c"\n')

# Update SBOM with correct checksums for updated expat files
files_to_update = {f"Modules/expat/{f.name}": f for f in updated_files}
Expand Down
Loading