Repository navigation
Conversation
El chequeo de {{...}} en wrangler.toml ahora salta comentarios TOML
(línea que empieza con # y # final fuera de comillas), así que un
comentario con {{D1_DATABASE_ID}} no bloquea el deploy si el valor real
ya está puesto.
Co-authored-by: santmun <santmun@users.noreply.github.com>
/kb/reindex ya no responde un 500 pelado si el índice tiene otra dimensión: avisa que bge-m3 usa 1024 y cómo recrearlo. forjabot doctor revisa la dimensión con wrangler vectorize info y avisa si no es 1024. Co-authored-by: santmun <santmun@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué cambia
deploy-checkya no bloquea el deploy por un{{...}}que solo aparece en un comentario dewrangler.toml./kb/reindexexplica cuando el índice de Vectorize no tiene 1024 dimensiones, yforjabot doctoravisa lo mismo.Por qué
Reporte de miembro 2F03C3 (2026-10-08).
# ... {{D1_DATABASE_ID}}(o un#al final de la línea) se leía como placeholder sin llenar, aunquedatabase_idya tuviera un UUID. El escaneo ahora ignora comentarios TOML y sigue marcando los placeholders que están en valores./kb/reindexrespondía "Internal Server Error". bge-m3 produce vectores de 1024. Ahora la respuesta dice recrear el índice con--dimensions=1024 --metric=cosine.forjabot doctorconsultawrangler vectorize infoy avisa si la dimensión no es 1024.No se publicó nada a npm ni se subió la versión del CLI.
Cómo lo probaste
pnpm testpasa (582 pruebas)pnpm typechecklimpioChequeo manual de
scripts/deploy-check.ts:wrangler.tomlcon{{D1_DATABASE_ID}}solo en un comentario#y en un#final, ydatabase_idcon UUID → exit 0.database_id = "{{D1_DATABASE_ID}}"→ exit 1, nombra el placeholder.Checklist
member/(config de cada quien)