Repository navigation
Marg gaia - #459
Merged
Merged
Marg gaia#459
Conversation
… resume fits without saving
sblunt
reviewed
Nov 4, 2026
|
|
||
| Currently only applicable to 1 massive companion. | ||
| REQ_PARAMS = ["ecc1", "inc1", "aop1", "tau1", "per1", "m1"] + ["dr4_jitter"] if fitting jitter | ||
| MARG_PARAMS = ["pm_ra", "pm_dec", "alpha0", "delta0", "plx", "u", "v"] |
Owner
There was a problem hiding this comment.
define u and v somewhere in this docstring
sblunt
reviewed
Nov 4, 2026
|
|
||
| log_conditional_prob = -0.5 * res.T @ precision_matrix @ res - 0.5 * logabsdet_covmatrix | ||
|
|
||
| log_conditional_prob -= (n_obs/2) * np.log(2*np.pi) # Figure out if half n_obs is right |
Owner
There was a problem hiding this comment.
half n_obs shouldn't matter for the mcmc since it's a constant wrt the fitting parameters
Add OFTeI_gaia test. Fix gaia marginalization aop*, sign of u,v.
Collaborator
Author
|
I think all feedback has been addressed except abstraction of automatic marginalization construction.
|
Collaborator
Author
|
It was tau reference epoch. All the previous tests with non-Gaia OFTeI marginalization happened to be using a reference epoch of 0. Marginalization tests now pass. |
Collaborator
Author
|
|
This was referenced Nov 17, 2026
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.