Repository navigation
test(gateway): take any whole seconds in a deploy's websites-not-ready message - #551
Merged
Merged
Conversation
…y message _wait_for_websites says how long it waited, the time measured, in whole seconds. Three tests matched "after 0s", which holds only while the wait takes under a second; on a loaded runner it took one, and CodeBuild's unit run failed on "websites not ready after 1s". They now match any whole seconds, and still match the rest of the message exactly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
deleted the
edgararakelyan/test-gateway-website-elapsed
branch
November 9, 2026 05:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a website isn't ready in time,
_wait_for_websitesfails the deploy saying how long it waited:"websites not ready after %ds: …", measured withtime.monotonic()and rounded down to whole seconds. Three tests inenv_gateway_provider_test.pymatchedafter 0s, which holds only while the wait takes under a second:test_a_site_that_never_says_it_is_ready_fails_the_deploy_naming_whytest_a_site_whose_ready_answers_no_website_readiness_is_never_ready_and_the_deploy_says_sotest_a_site_past_the_time_it_declared_fails_the_deploy_saying_soOn a loaded runner the wait took a second. CodeBuild's unit run for #547 failed with
Actual message: 'websites not ready after 1s: mail (not ready after 0 s: @ready_check seeded returned False)'(1 failed, 13,982 passed). The same tests passed on that PR's previous commit and in GitHub'sunitjobs.The three tests now match
after \d+s. The rest of each message is still matched exactly, including the site's ownnot ready after 0 s, which comes from its answer, not the clock. No code changes.Testing
ruff checkis clean.🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge.Summary
The PR removes a timing assumption from three website-readiness tests.
Reviews (1) · Last reviewed commit: "test(gateway): take any whole seconds in..." · Reviewed by Greptile