Repository navigation
docs(local): a supervisor kills the run's process group and retries a sandbox not fully gone - #564
Merged
Merged
Conversation
… sandbox not fully gone Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…its group spares the supervisor Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of FD-5375.
Two additions to the recipe in #555 for cleaning up after a killed run (
run_bundle's docstring,.env.exampleandlocal_sandbox_ids()'s docstring):/proc, which macOS doesn't allow, so on macOS only killing the group stops them. On Linux it also stops commands mid-start.terminate_sandboxraises, and retry it. Since fix(local): retain sandbox folders after incomplete teardown #561, that raise means the sandbox isn't fully gone: Docker couldn't list or remove one of its objects, or one of its processes survived. Its folder is the identity a retry needs.Docs only: no code or behavior changes.
🤖 Generated with Claude Code


Confidence Score: 5/5
The documentation changes appear safe to merge.Summary
Updates the local sandbox cleanup recipe. No runtime behavior changes.
Reviews (2) · Last reviewed commit: "docs(local): a supervisor starts the run..." · Reviewed by Greptile