Repository navigation
feat(website): a website env's ready_timeout_s and shm_mb, for a site slow to boot - #590
Merged
earakely-scale merged 3 commits intoNov 10, 2026
Conversation
… slow to boot A website env takes ready_timeout_s, how long its server may take from its container starting to ready, and shm_mb, its server's /dev/shm in MiB, in env.toml, the stored env and agent-env env website put. The gateway's health check of the server allows the timeout before it counts a failure (start_period), and the deploy waits it, or as long as the site's card says if longer, so a third-party image that answers nothing for minutes deploys rather than failing after about a minute. shm_mb sets the server container's shm_size. Without them, nothing changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…minute, to keep CI's shard short Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…1-m833-website-env-a-boot-timeout-for # Conflicts: # AGENTS.md
earakely-scale
deleted the
edgararakelyan/fd-4981-m833-website-env-a-boot-timeout-for
branch
November 10, 2026 15:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A website env can now say how long its site may take to be ready and how much shared memory its server needs:
ready_timeout_sandshm_mb. They go inenv.toml, in the stored env, and onagent-env env website put(--ready-timeout-s,--shm-mb). They apply wherever a website env deploys through the gateway, alone or as a multi env's website child.This is M8.33 (FD-4981). It's for third-party site images such as WebArena's GitLab or shopping (M8.36 to M8.38), which can take minutes to boot and want more than Docker's 64 MiB of
/dev/shm.Today:
start_period: 30sand 3 retries, so a server that answers nothing for about a minute is marked unhealthy.depends_onthat server being healthy, sodocker compose upthen fails the deploy, whatever the deploy's own readiness wait (300 s, or what the card declares) would have allowed.shm_size.With the fields:
start_periodisready_timeout_s, rounded up to whole seconds. Its interval, timeout and retries are unchanged, so a silent server is still noticed about 30 s after its time, and a check that passes earlier marks it healthy at once.readytimeout andready_timeout_s, plus the usual 30 s margin, and never less than today's 300 s. Every protocol card declares a timeout (300 s by default), so letting the card's always win would have madeenv.tomlunable to extend the wait.shm_mbis the server container'sshm_size.Decisions (FD-4981)
ready_timeout_sandshm_mb, as the protocol's@website(ready_timeout_s=)and the apps'@linux(shm_mb=)name them.ready_timeout_sis any positive number of seconds, as@websiteaccepts.shm_mbis 1 to 65536 MiB, sharing the apps'MAX_SHM_MB.start_periodtakes the timeout, and the rest of the health check is unchanged.env.tomldeclares them, with no protocol change. The wait takes the longer of the card's and the env's.Both are checked at put, in the constructor, the env.toml check and the CLI, with the same messages.
Tests
inf,trueand1.5);env.tomlaccepts them and refuses bad values before any write;start_periodandshm_sizefollow them, and are30sand absent without them;gateway_test.pytest deploys a fixture site (tst/data/slow_boot_website) that answers nothing for 100 s, past the health check's minute, withready_timeout_s = 160andshm_mb = 1024. It reads the server's/dev/shmthrough the gateway: 1 GiB. The same site with no timeout fails the deploy at its server's health check, as today..gitin the synced tree, nohttpxin the system Python).m833-slow-boot-site-server:m833-slow-boot-site(answers nothing for 180 s,ready_timeout_s = 240) deploys in 219 s, and its server's/dev/shmreads 1073741824 bytes through the gateway;m833-slow-boot-site-default, the same site without a timeout, fails after 72 s withslowboot-website-backend failed its health check;🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Adds
ready_timeout_sandshm_mbto website envs.The previous and current commits have different merge bases with the target commit, so this review covered the full PR diff. No previous review threads were supplied. No new actionable issues were found.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR A["env.toml or CLI"] --> B["WebsiteEnv"] B --> C["Stored env"] C --> D["website_config"] D --> E["Compose start_period and shm_size"] D --> F["Website readiness wait"]Reviews (8) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile