Repository navigation
feat(computers): Chromium on the desktop goes out through the egress proxy by policy, and X never blanks (FD-5481) - #673
Merged
earakely-scale merged 9 commits intoNov 13, 2026
Conversation
…proxy by policy, comes back after a crash, and X never blanks (FD-5481) - The ubuntu-24.04 base gives every Chromium build an app brings a managed policy (agentenv-egress.json in Chrome for Testing's, Chromium's, the snap's and Chrome's folders): ProxySettings fixed_servers at the egress proxy, bypassing what the session's NO_PROXY does, and WebRtcIPHandling disable_non_proxied_udp. It's the base's, not the chromium app's, since the same app runs on the browser computer, whose site proxy its own flags name. - A website browser that a signal or a failing code ends is launched again by its server (AppRuntime relaunch_on_crash, cause "crash"), up to CRASH_RELAUNCHES (5) times a boot; one that exits cleanly was closed and stays so, and one its server stopped is its server's to start. - Xvfb runs with no screensaver and no DPMS (-s 0 -dpms), whose timeouts run on real time. - Chromium's network time queries were off already (QUIET_POLICIES). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… launched again, so it starts afresh On the host, a SIGKILLed Chromium was never launched again: its helpers outlived it for a moment, so its session still counted as the app running, and the relaunch reached for a window over its closed pipe instead of starting a browser. What's left of the crashed session is now stopped first. The integration test waits for the crash's launch in the app's log, and the browser probe's pgrep pattern no longer matches the probe's own command line, which had passed it off as a browser when none ran. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…o data call changes its profile as it starts The relaunch after a crash ran beside the data plane's calls (Greptile): a data/reset or load arriving as it started found the dead pid, counted the app stopped and replaced the profile while the new browser read it. The app's turn, the lock those calls and launches take, moves from AppDataPlane to AppRuntime, and the relaunch holds it, skipping when anything launched the app since the crash (by the launch log: a data call that found it gone clears the pid file without launching it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… again for the crash chromium_app_test's launch-cause test and the browser computer's two chaos tests killed the browser and expected it to stay down, to be launched from the menu or to fail every call after. It now comes back by itself, so the launch-cause test reads boot, the kill's exit, then a launch for the crash; and the chaos tests hold that calls with the browser killed answer at once, failing while it's gone, and work again once it's launched again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…one to readiness An exit the app's server launches it again after is logged relaunching, and apps.ended_on_its_own reads only the latest launch's exit, so the page driver's final readiness check waits for the relaunch instead of failing at the crash; a relaunch that fails is logged relaunch_failed and fails it at once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r restarts comes back with it A website browser's relaunches after a crash wait 1 s, doubling with each crash, instead of following at once: killing the X server took the browser with it, and its five relaunches, each failing without X, could be spent before supervisord had X back or not, so the computer came back or failed for good by a race. The browser computer's kill tests now expect a killed browser and a killed X server to come back, and one killed past its relaunches to fail it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…th its X server for good Chromium exits with code 0 when its X server goes, a close, so its server never relaunched it there and the X server kill test was never a race: the backoff fixed nothing. The kill test keeps its fix: a killed browser comes back, and one killed past its relaunches fails the computer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rowser computer as before The relaunch after a crash, and the readiness and tests it changed, come out: a crash is an infrastructure failure, better failed and retried than run on with a fresh browser, and it was most of this change's complexity. The browser computer fails for good when its browser crashes, saying why, as on main; on the desktop the browser stays gone until its launcher opens it again. The proxy policy, network time off and the screensaver off stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e frame, not from the first capture The control arms its NUDGE_S wait before its first capture's task sends it, so the first capture is sent a moment after the wait starts and the second can follow it by a hair under NUDGE_S (0.49966 s on a loaded runner). Timing the second from before the frame call is what the control promises. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
deleted the
edgararakelyan/fd-5481-hb110-chromium-and-the-desktop-on-the
branch
November 13, 2026 23:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Chromium is the agent's main window onto sites, and it has to keep working when the computer's clock jumps (FD-5481, HB1.10). Three parts:
Proxy policy. The
ubuntu-24.04base gives every Chromium build an app brings a managed policy,agentenv-egress.json:ProxySettingsisfixed_serversat the egress proxy (http://127.0.0.1:3128), bypassing what the session'sNO_PROXYdoes: localhost, loopback andhost.docker.internal.WebRtcIPHandlingisdisable_non_proxied_udp, as the browser computer's flags already set.Before this, the desktop's Chromium went through the proxy only because it read the session's environment under XFCE. The policy makes it so however the browser is launched. It lives in the base, not the chromium app, because the same app runs on the browser computer, which goes out through its site proxy by its own flags. Routed sites need no bypass, since the egress proxy hands them to the site proxy.
Network time off. It already was (
BrowserNetworkTimeQueriesEnabled: falsein the app'sQUIET_POLICIES).No screensaver. Xvfb runs with
-s 0 -dpms. Its screensaver's 600 s timeout and its DPMS ran on real time.FD-5481 also asked for a relaunch after a crash. It's left out: a crash is an infrastructure failure, better failed and retried than continued with a fresh browser that has lost its tabs and page state, and it was most of this change's complexity. As on main, the browser computer fails for good when its browser crashes, saying why; on the desktop the browser stays gone until its launcher opens it again. The crash the prototype found, a browser context disposed while it holds a hidden page, is FD-5842.
Behaviour to know about
website_browser_test.BROWSER_PROCESS) found a browser bypgrep -f -- --remote-debugging-pipe, which matched the probe's own command line when no browser ran. Its pattern is now[-]-remote-debugging-pipe.test_browser_recording's nudge test checked that the second capture came at leastNUDGE_S(0.5 s) after the first, and failed on this PR'sunit (2/2)with 0.49966 s. The control starts its first capture withensure_futureand then arms itsNUDGE_Swait, so the first capture is sent a moment after the wait starts. The control is right; the test now times the second capture from before theframecall.Testing
test_computer_egress_base.pyHTTPS_PROXY, its bypass list the session'sNO_PROXY, and the Dockerfile installs it in each folder site routing writes to; Xvfb runs with-s 0 -dpmsshipped_computers_test.pytest_browser_recording.pychromium_universe_test.py(new), the chromium desktop on local Dockerxset qshows no screensaver or DPMS; the policy is installed🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge, with no outstanding findings.Summary
The PR makes desktop Chromium use the egress proxy through a managed policy and disables Xvfb screen blanking.
Reviews (12) · Last reviewed commit: "test(browser): the nudge test times the ..." · Reviewed by Greptile