Skip to content

fix(release): chromium's compose writes its record in a folder of its own, and its first push needn't be answered - #713

Merged
earakely-scale merged 3 commits into
mainfrom
edgararakelyan/fd-5908-release-computer-folders
Nov 16, 2026
Merged

earakely-scale merged 3 commits into
mainfrom
edgararakelyan/fd-5908-release-computer-folders

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

v0.9.1544's chromium compose resolved, built and probed chromium ready on arm64 (2 min 13 s), then failed writing its record: PermissionError: ... /home/runner/work/_temp/computers/composed. The registry step mounts $RUNNER_TEMP/computers/registry before anything makes it, and Docker makes a missing folder it mounts root's, computers/ with it. My VM run had made the folder first, so it never showed.

Going over the rest of the jobs for such differences found one more: computer-publish fails when it can't tell whether the chromium index exists, and GHCR may refuse a token a package before its first push, which this release's is.

What changes

  • computer-build makes $RUNNER_TEMP/computers/registry and .../composed before it starts the registry.
  • publish-computers takes an index the registry won't say it has as unpublished, with a warning, and creates it, as infra_images.py takes a refused package for the first publish.
  • Tests for both.
  • Temporary, now removed (d16e634): .github/workflows/computers-dry-run.yml, generated from computer-build as publish-pypi.yml has it, so it runs the release's own steps on GitHub's amd64 and arm64 runners; then the publish step's join and verify-record with a local registry on 5001 standing in for ghcr; then an install of a wheel carrying that record composing chromium, which must pull it and resolve and build nothing.

How it was tested

  • tst/unit/test_release_infra_images.py and tst/unit/test_infra_build_script.py: 138 passed.
  • actionlint: no errors in either workflow.
  • The dry run passed on this pull request, on GitHub's runners:
    • computer-build composed and probed chromium on amd64 and on arm64, and each wrote its record.
    • The publish step joined them as one index in the stand-in registry, and verify-record passed.
    • An install of a wheel carrying that record took both arches from it, probed amd64 ready in 46 s, deployed chromium in 3 s, and resolved and built nothing.

bump-version.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Fixes Chromium release publishing by creating writable folders before Docker starts and allowing a first publish when GHCR refuses the initial lookup.

  • Chromium's release job prepares its folders before Docker mounts them.
  • The first chromium image push proceeds when GHCR refuses an index lookup.

Reviews (2) · Last reviewed commit: "ci: remove the temporary dry run of the ..." · Reviewed by Greptile

earakely-scale and others added 2 commits November 16, 2026 10:53
… own, and its first push needn't be answered

v0.9.1544 composed and probed chromium, then couldn't write its record: Docker had made the folder the local registry's
storage is mounted from root's. The folders are made first. And GHCR may refuse a token a package before its first push,
so computer-publish takes an index the registry won't say it has as unpublished, with a warning, and creates it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nners, removed before this merges

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…h passed

On GitHub's amd64 and arm64 runners: chromium composed and probed on each, joined as one index in a stand-in for ghcr,
the record verified, and an install of a wheel carrying it pulled both arches, resolving and building nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale merged commit 7eb49b4 into main Nov 16, 2026
35 of 36 checks passed
@earakely-scale
earakely-scale deleted the edgararakelyan/fd-5908-release-computer-folders branch November 16, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant