Skip to content

Revert SWE Destroyer port defaults commit#280

Merged
danielmillerp merged 1 commit intomainfrom
dm/revert-swe-destroyer-port-defaults
Mar 3, 2026
Merged

Revert SWE Destroyer port defaults commit#280
danielmillerp merged 1 commit intomainfrom
dm/revert-swe-destroyer-port-defaults

Conversation

@danielmillerp
Copy link
Contributor

@danielmillerp danielmillerp commented Mar 3, 2026

Summary

  • Reverts commit 89097c0 which was never meant to be merged
  • That commit replaced hardcoded port defaults with constant imports from ports.py in environment_variables.py and deploy_handlers.py
  • Restores the original inline defaults

Test plan

  • Verify environment_variables.py has original default values
  • Verify deploy_handlers.py uses hardcoded "8000" port

🤖 Generated with Claude Code

Greptile Summary

This PR reverts commit 89097c0 which introduced imports from a non-existent module (agentex.lib.constants.ports). That commit would have caused ImportError at runtime. The revert restores the original inline default values in both files.

  • Restores inline defaults in environment_variables.py: TEMPORAL_ADDRESS = "localhost:7233", AGENTEX_BASE_URL = "http://localhost:5003", ACP_PORT = 8000, HEALTH_CHECK_PORT = 80
  • Restores hardcoded "8000" port in deploy_handlers.py uvicorn commands
  • Removes broken import of ACP_SERVER_PORT from agentex.lib.constants.ports (module does not exist in repository)

Confidence Score: 5/5

  • This PR is safe to merge — it fixes a broken import that would cause runtime failures.
  • The PR is a clean revert of a commit that imported from a non-existent module (ports.py). The restored inline defaults exactly match the pre-89097c0 state. No behavioral changes beyond fixing the broken import.
  • No files require special attention.

Important Files Changed

Filename Overview
src/agentex/lib/environment_variables.py Correctly reverts import of non-existent ports.py constants and restores original inline defaults. Minor extra blank line at top of file.
src/agentex/lib/cli/handlers/deploy_handlers.py Correctly removes import of non-existent ACP_SERVER_PORT constant and restores hardcoded "8000" port string in uvicorn commands.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["environment_variables.py"] -->|"reverted import from"| B["constants/ports.py (non-existent)"]
    C["deploy_handlers.py"] -->|"reverted import from"| B
    A -->|"restored inline defaults"| D["TEMPORAL_ADDRESS = localhost:7233\nAGENTEX_BASE_URL = http://localhost:5003\nACP_PORT = 8000\nHEALTH_CHECK_PORT = 80"]
    C -->|"restored hardcoded port"| E["uvicorn --port 8000"]
    style B fill:#f96,stroke:#333,color:#000
    style D fill:#6f6,stroke:#333,color:#000
    style E fill:#6f6,stroke:#333,color:#000
Loading

Last reviewed commit: fdda7a5

@danielmillerp danielmillerp requested a review from RoxyFarhad March 3, 2026 21:08
@danielmillerp danielmillerp merged commit e373614 into main Mar 3, 2026
30 of 31 checks passed
@danielmillerp danielmillerp deleted the dm/revert-swe-destroyer-port-defaults branch March 3, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants