Repository navigation
Validate offline UI scenario data against issue-owned authority - #820
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 017c733a-252b-471a-9c43-26a6a67554df Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Add independent visual-component and healthy-root negatives and isolate each synthetic case. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 017c733a-252b-471a-9c43-26a6a67554df Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Exercise the no-read refusal with a controlled drive-type probe. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 017c733a-252b-471a-9c43-26a6a67554df Signed-off-by: Colin Neilens <coneilen@microsoft.com>
coneilen
force-pushed
the
coneilen-microsoft-ui-claim-foundation-g1
branch
from
October 14, 2026 19:10
b8472c0 to
d1abb6e
Compare
coneilen
marked this pull request as ready for review
October 14, 2026 19:58
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bind offline scenario data to an independently supplied issue-authority snapshot without letting scenarios redefine acceptance criteria. Validation reports valid data, never verified UI, human approval, parity, or issue closure.
Refs #818. Implements G1 only under the approved plan and binding scope correction.
Changes
Acceptance checklist: all five G1 implementation contracts are addressed: convention, external authority binding, strict data validation, behavioral RED plus executable registration, and explicit evidence limits. All Windows UI acceptance claims, G2/G3 work and runtime evidence remain outside this PR. No plan deviation; the bounded read and absolute-end identifier patterns enforce the approved limits rather than adding scope. PowerShell 7.5+ is documented for string-preserving JSON conversion.
Test plan
RED: pwsh -NoProfile -File Tools\windows\Tests\UiScenario.Tests.ps1 -> positive valid fixture passed, then RED: callable validator accepted wrong authority revision (incremental WIP, not a main-versus-head product regression)
GREEN: pwsh -NoProfile -File Tools\windows\Tests\UiScenario.Tests.ps1 -> All 166 offline contract tests passed; executed=166, passed=166, failed=0
REGRESSION: gh run list -R scgopi/GraphCode --commit d1abb6e --limit 20 --json databaseId,name,headSha,status,conclusion -> all 7 workflow types succeeded; recorded 24 checks: 22 success/2 deliberate skips; hardening run 38621462157 jobs 116049863649 and 116049863737 each executed UiScenario166/passed166/failed0
Local regressions also passed:
pwsh -NoProfile -File Tools\windows\Tests\ValidationRunner.Tests.ps1(actual new child 166/166/0, then PASS),bash Tools/ci/tests/classify-changes.test.sh(62 passed/0 failed), and unchangedpwsh -NoProfile -File Tools\tdd\Tests\TddEvidence.Tests.ps1(PASS).The preserved RED (
red-authority.log) is a behavioral failure of an otherwise callable parser/schema validator before authority binding was implemented. WIP validator/test copies and SHA-256 records are retained separately from GREEN. Additional retained iterations: the first GREEN attempt reported a toolingValidationErroron valid data; a later boundary test exposed final-newline acceptance by regex$, corrected with absolute-end assertions. Neither failure is silently substituted with a passing log.The preliminary Sonnet 5.5/high review found a UNC-path guard precedence bug and two independent negative-test gaps. A mocked-filesystem probe reproduced the path defect without network I/O (
red-review-path-guard.log); normalized paths now reject UNC/device/ADS before reads. The same no-network invariant also rejects mapped network drives using local drive-type information, with a controlled no-read RED retained asred-mapped-drive.log. Tests independently reject visual component scenarios and self-anchored absence assertions. One review-fix run hit a fixture file-sharing error during repeated deletion; the failure is retained (green-review-final.log), and fresh per-case scratch paths avoid that reset pattern without retrying or hiding failures.Local evidence lives in worker-owned
C:\gcs\ig\logs:red-authority.log,red-source-hashes.txt,red-validator.ps1,red-tests.ps1,green-attempt-1.log,green-boundaries-1.log, initialgreen-final.logandregression-runner-final.log(154 cases), intermediategreen-review-attempt-2.logandregression-runner-review-attempt-2.log(165 cases), finalgreen-final-166.logandregression-runner-final-166.log(166 cases),green-final-source-hashes.json,regression-classifier-final.log, andregression-tdd-final.log. Initial-head CI hardening job 116017091708 in run 38611878304 independently logged UiScenario executed=154/passed=154/failed=0; it is not final-head evidence.Retained pre-rebase CI failure: on
b8472c0058fdccb74ee3b9aeb8297ff4784bf838, Windows shell run 38616560122/job 116033394023 failed withScrubbed production shell startup failed with exit code -1073741502at 18:47:21Z. This is the wrapper's childpwsh -File ScrubbedShellStartup.Live.Tests.ps1status, with no structured startup result; a product/DLL/infrastructure root cause is not established. Smoke/stress immediately before it passed; the diagnostic-upload/post-checkout steps also failed, and no UIA diagnostics artifact was retained by CI. The raw failed job log is preserved locally asci-b847-integration-failed-job.logand is not replaced by a passing rerun. One retry of this job on the same SHA passed (job 116042866083, run attempt 2), includingSCRUBBED_SHELL_STARTUP: PASS; executed=5; all seven workflows on that SHA then succeeded (22 successful checks, two deliberate skips). No local native/broad suite or gate/product change was made. Both pre-rebase hardening jobs 116033105535 and 116033105589 in run 38616560047 independently logged UiScenario executed=166/passed=166/failed=0. These remain historical, not rebased-head evidence.Fresh-base rebase: after preserving the completed retry measurement, rebased onto accepted documentation-only main
dd501e1befd3e00f9e31254a3c1c0c6595543c29for strict required-check freshness. Current head isd1abb6ec0f9ca2e3820915426c367ddbd0188ae0. The full eight-file G1 diff and all validator/test/schema bytes are identical before and after rebase (rebase-final-diff.patchversusrebase-dd501e-diff.patch, andgreen-final-source-hashes.json).docs-rebase-range-diff.logshows all three commits unchanged (=);docs-rebase-no-source-delta.logconfirms no product/tooling/scenario delta. Per the user-directed cheap-docs-rebase rule, existing source-review acceptance and 166-case evidence were preserved without another source-review pass or focused rerun solely for the rebase. The table above records fresh d1 CI, not substituted older green runs.Retained rebased-head CI failure: macOS run 38621462134/job 116049841522 on the exact
d1abb6echead failed duringmise exec -- make install-zmx, before app tests: pinned Zig 0.15.2 reportedLibCInstallation.zig:174: return error.DarwinSdkNotFound, then make exited 2. This establishes a build-time SDK-discovery failure, not which lookup failed, an image root cause, a G1 behavioral failure, or product runtime behavior. The failed output is retained inci-d1-macos-failed.logand setup context inci-d1-macos-first-full.log. The one exact-job retry succeeded (job 116053157341;ci-d1-macos-retry-pass.log); no SDK, tool pin, workflow, product or G1 source change was made for it, and the original failure is not overwritten.Fresh-head CI catalogs and logs are retained under the same owned log root:
ci-rest-d1abb6-retry.json,ci-final-runs-d1.json,ci-final-checks-d1.json,ci-d1-hardening-jobs.json,ci-d1-hardening-2025.log,ci-d1-hardening-2022-rest.log,ci-d1-shell-jobs.json,ci-d1-integration-pass.log,ci-d1-port-jobs.json,ci-final-macos-d1-jobs.json, and the TDD/DCO/Linux job catalogs. The different-vendor Sonnet 5.5/high agent accepted the corrected source and final-166 local evidence; final published-body/CI evidence verification is reported separately to the coordinator. This is agent review, not issue-authority human approval.Not verified: human approval/authentication of authority exports; live UIA uniqueness, ownership or patterns; input/physical keyboard; rendering/screenshots; fixture installation/executor-version compatibility; actual cleanup, persistence, parity or claim closure. Locally, no product executable, native suite, desktop, Sandbox or WinApp installation was used. Full product unit/integration validation and
make test/make checkwere not run locally; exact-head hosted CI is the regression gate. There is no screenshot claim or desktop slot for G1.Checklist
git commit -s) per the DCOmake test)make check)