Skip to content

fix: do not render in AddDetail when visible is false - #245

Open
AdamMagued wants to merge 1 commit into
schollz:mainfrom
AdamMagued:fix-issue-236
Open

AdamMagued wants to merge 1 commit into
schollz:mainfrom
AdamMagued:fix-issue-236

Conversation

@AdamMagued

Copy link
Copy Markdown

Fixes #236

Summary

  • Checked config.visible in AddDetail to prevent unwanted terminal rendering when visibility is disabled.
  • Added unit tests verifying invisible progress bar does not render on detail updates.

Verified via container sandbox test suite.

Signed-off-by: AdamMagued <adamismailmageud@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AddDetail cause progressbar to render even when visible is false

1 participant