Repository navigation
Remove the occupied static modifier from being used again and lua fix - #2347
Merged
schombert merged 2 commits intoNov 5, 2026
Merged
Conversation
Prevent lua state from not being initialized properly if it's in MP or linux Call close_lua on state destruct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove occupied modifier from being used again cos its too unbalanced
Move the scenario lua init further up in function call. It was accidentially left below the LLVM block, which meant in MP or linux it did not get initialized properly
Call
lua_closeon state destruct if it was init previously (not nullptr). Not needed when playing the game, but nice to clean up each lua state if multiple scenarios are being created within a single session.