Repository navigation
Military UI updates and linux fixes & bug fixes - #2354
Merged
schombert merged 8 commits intoNov 8, 2026
Merged
Conversation
Implement sorting in the leader window, and fix admirnals not showing a location
…d icons Fix being at war not cancelling military access properly, and not being able to trucebreak
Ensure you cannot select a province while shift-selecting units Ensure no way to select both armies and navies at the same time
Fix sound effects overidding eachother, should behave like windows build Fix interface sounds not being loaded in Linux due to using windows slashes in the path to the folder
Ensure the linter catches provinces not assigned to state Move the "show all saves" checkbox to be apart of the playable nation subwindow, so it dosen't look bad on other resolutions
…inux-fixes # Conflicts: # src/gamestate/system_state.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables foreign investment for now. WIth the logistics system, there isn't a good easy way to represent it which dosen't have major flaws (It isn't either in base Vic2, but its very apparent when the goods actually has to be transported). When ownership is more concretely defined, it can be re-enabled.
Fully implement the "Selectbox" way of quickly selecting a subset of the currently selected units, which was absent previously. This also requires implementing the "on_key_up" hook, since it is activated by letting go of Shift in the main game scene. Also fix some minor unit selection inconsistencies
Fix Shift/Ctrl keys not being properly registered on Linux in many cases due to it being registered as R/L shift and R/L ctrl
Add bunch of missing tooltips and UI stuff in the military window. Add sorting of generals and units as per [Missing Feature] Leader Types Cannot Be Sorted #2299
Fix sound effects being constantly cut off by new ones on Linux. It is changed to work similarly to the windows build. Also fix click-sound effects not loading in Linux because of wrong file seperator
Add fatal error if a province is not defined in a state on scenario creation
Fix wrong tooltip on adding wargoal
Extend sanity check in
add_to_warto ensure that the joiner cannot ever be at war with any existing participant in the war they are about to join, rather than just checking if the joiner is already in the war. Crisis wars and wars started by effects could go afoul of this if the sanity check is not present.