fix: use 2-space indentation in generated manifests YAML output#89
Merged
mathieu-benoit merged 2 commits intomainfrom Apr 12, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/score-spec/score-implementation-sample/sessions/e09ef95b-aa59-49f9-817c-f9477a32e3c5 Co-authored-by: mathieu-benoit <11720844+mathieu-benoit@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
score-implementation-sample generatewas emitting YAML manifests with 4-space indentation instead of the standard 2-space.Description
The
generatecommand was callingyaml.NewEncoder(out).Encode(manifest)directly, which usesgopkg.in/yaml.v3's default 4-space indentation.Fix: Create the encoder separately and call
enc.SetIndent(2)before encoding:Test expectations in
generate_test.goupdated to reflect 2-space indentation.This mirrors the fix applied in score-spec/score-compose#461.
What does this PR do?
Fixes 4-space indentation in YAML manifest output from
score-implementation-sample generate, aligning it with standard YAML formatting conventions.Types of changes
Checklist: