Skip to content

Reword conflict comment to avoid retargeting confusion#31

Merged
Phlogistique merged 1 commit intomainfrom
conflict-comment-wording
Apr 8, 2026
Merged

Reword conflict comment to avoid retargeting confusion#31
Phlogistique merged 1 commit intomainfrom
conflict-comment-wording

Conversation

@Phlogistique
Copy link
Copy Markdown
Collaborator

@Phlogistique Phlogistique commented Apr 8, 2026

Adds a trailing sentence to the merge-conflict PR comment reassuring the reader that they only need to push their conflict resolution. Without it, a reader might assume they also need to run gh pr edit --base themselves, which would not work because the synthetic merge commit would not be produced.

The prior wording ("I will pick-up from there and continue retargetting")
risked reinforcing the idea that users might need to run `gh pr edit --base`
themselves. It also oversold the scope — only the commented PR is resumed,
not "the stack".
@Phlogistique Phlogistique merged commit 908602b into main Apr 8, 2026
2 checks passed
@github-actions github-actions bot deleted the conflict-comment-wording branch April 8, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant