Expose the shard name and remaining bucket in the user:$id/cpu message#57
Open
tiennou wants to merge 1 commit intoscreeps:masterfrom
Open
Expose the shard name and remaining bucket in the user:$id/cpu message#57tiennou wants to merge 1 commit intoscreeps:masterfrom
user:$id/cpu message#57tiennou wants to merge 1 commit intoscreeps:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is that this lets the client know (for MMO) which shard the received message belongs to, possibly letting it filter out the one that correspond to the currently viewed shard instead of being random.
bucketis just there because some people thought having the bucket in the UI would also be nice.Caveat: this is assuming a lot about how MMO handles its sharding, which is private code; so the current way is based on what driver does, with a previous get for the value
screepsmod-admin-utilsuses.Discord Issue: https://discord.com/channels/860665589738635336/1493610087334547497