Repository navigation
DALI 306 - #158
Open
markus-becker-tridonic-com wants to merge 3 commits into
Open
DALI 306#158markus-becker-tridonic-com wants to merge 3 commits into
markus-becker-tridonic-com wants to merge 3 commits into
Conversation
The IEC 62386-306 Annex A, Table A.1 unit-of-measurement list ends at 53 (parts per million). Real hardware (Lunatone sonuSense) reports unit codes beyond that: 55 for A-weighted sound pressure level and 56 for a manufacturer-defined probability instance. Decode them instead of surfacing them as unknown values, clearly marked as non-306 extensions. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sde1000
reviewed
Oct 7, 2026
|
|
||
| class QueryMeasurementVariable(general._StandardInstanceCommand): | ||
| """Query a Part 306 measurement variable selected by DTR0.""" | ||
|
|
Owner
There was a problem hiding this comment.
If sending this command increments DTR0, it would be a good idea to mention it in the command description here in addition to mentioning it in the docstring for the MeasurementVariable enum.
There was a problem hiding this comment.
Done in 9da4969. 01a5544 should be dropped, instead:
class UnitOfMeasurement(IntEnum):
# ...
# Clarifications and Recommendations for IEC 62386:
DECIBEL_A = 54
class QuantityName(IntEnum):
"""Standard quantity-name values from Part 306 Annex A, Table A.2."""
# ...
# Clarifications and Recommendations for IEC 62386:
GENERAL_PURPOSE_COUNTER = 59
PEOPLE_COUNTER = 60
Document the DTR0 auto-increment behavior on the command itself, not only on the MeasurementVariable enum, so callers see it where they issue the query. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IEC 62386-306 general sensor support
Summary
Adds support for IEC 62386-306 general sensors (instance type 6): the command and event classes, the measurement-metadata queries (resolution, magnitude, unit, quantity, signedness), and the Annex A enumerations for unit of measurement and quantity name — with tests.
What's included
GeneralSensorEventplus the Part 306 measurement-variable queries and theUnitOfMeasurement/QuantityNameenumerations from Annex A, Tables A.1 and A.2.Testing
python3 -m pytest dali/tests/— 114 passed, including the general-sensor decoding tests.Note for reviewers
The second commit (vendor unit codes 55/56) is intentionally kept separate from the standards-compliant support so it can be dropped independently if you'd rather not carry non-standard vendor codes in the core enum.