Repository navigation
feat(updates): check for a newer release by default (ADR-0178 points 2-4) - #485
Open
jeffcrouse wants to merge 2 commits into
Open
jeffcrouse wants to merge 2 commits into
jeffcrouse wants to merge 2 commits into
Conversation
…2-4) - update_channel defaults to "beta" (every release so far is a beta, and "stable" skips them). - A stored "disabled" is migrated once: settings.json saved every default, so it records no choice. Logged, remembered in update_channel_migrated (kept out of the settings view), and never repeated, so a server turned off afterwards stays off. - deploy-dev writes VERSION=dev into the container, so a hand-deployed server skips the check instead of announcing a release older than its code (the NAS reported beta22 while running newer code). - CONFIGURATION.md says what is sent and how to turn it off. No API schema change: SettingsResponse lists its fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jeffcrouse
force-pushed
the
feat/adr-0178-server-update-check
branch
from
November 11, 2026 22:31
a9c6bab to
90d3c01
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server half of ADR-0178 (#484), points 2 to 4. The Apple banner follows in familiar-apple.
update_channeldefaults to"beta". Every release so far is a beta, and thestablechannel skips betas._savewrites every field, so a stored"disabled"records no choice (the NAS holds one nobody picked). On load, it becomes"beta"once. The server logs it, including how to turn it off, and setsupdate_channel_migratedso it never repeats. A server turned off after that stays off. The flag is kept out of the settings view, andSettingsResponselists its fields explicitly, so there's no schema change.deploy-devwritesVERSION=devinto the container. The NAS reportedv0.2.0-beta22while running newer code, and with the check on it would have announced beta24.docs/CONFIGURATION.mdgets "Update checks" (what is sent: a plain GET for the public release list; GitHub sees the IP) and where to turn it off: Server → Health → Release channel. The changelog has an Unreleased entry.Tests:
tests/test_update_channel_default.py, 8 tests. Run against the oldapp_settings.py(with only the constant added), 4 fail: the default, the migration, a pre-setting file and the marker. The other 4 are guards that a channel someone chose is never undone. Backend suite: 2674 passed, 18 skipped.make checkpasses.ADR-0178's Implementation block records this half.
🤖 Generated with Claude Code