Skip to content

fix: resolve proxy-addr to 2.0.8, 2.0.7 is curation-blocked - #1409

Merged
MichaelGHSeg merged 1 commit into
masterfrom
fix/proxy-addr-curation
Nov 17, 2026
Merged

MichaelGHSeg merged 1 commit into
masterfrom
fix/proxy-addr-curation

Conversation

@MichaelGHSeg

Copy link
Copy Markdown
Collaborator

Summary

Artifactory returns 403 for proxy-addr@2.0.7, which fails a cold-cache yarn install. That broke the 1.84.4 release run (https://github.com/segmentio/analytics-next/actions/runs/44124753244): the build job failed, so publish and deploy-cdn never ran.

test passed in that run only because it restores the yarn cache (cache: 'yarn'); build, publish and deploy-cdn install from scratch.

proxy-addr is a transitive dependency of the root express@^4.18.2 devDependency, which pins ~2.0.7. 2.0.8 (2026-09-15) has identical dependencies, so this adds a resolution, the same approach as the axios (#1386) and is-email (#1388) fixes.

Changes

  • package.json: "proxy-addr@~2.0.7": "^2.0.8" in resolutions
  • yarn.lock: proxy-addr 2.0.7 to 2.0.8, nothing else

Test plan

  • yarn install --immutable passes locally; yarn why proxy-addr shows express 4.18.2 resolving to 2.0.8
  • yarn build and the pre-push typecheck pass
  • CI installs cold because the lockfile hash changed, which exercises the Artifactory fetch of 2.0.8 from the CI identity. A green test job confirms it.
  • After merge: run publish.yml via workflow_dispatch on master and approve the production gate to release 1.84.4

No changeset: this only changes a root devDependency resolution, so changeset-bot reporting none is expected.

Artifactory returns 403 for proxy-addr@2.0.7, which breaks cold-cache
installs (the release build/publish/deploy-cdn jobs don't restore the yarn
cache). Same approach as the axios and is-email resolutions.
@twilio-earthly-lunar-2

Copy link
Copy Markdown

🌙 Earthly Lunar

❌ 1 Failing
  • ❌ backstage-report.system-valid - catalog-info.yaml should define a spec.system that exists in Backstage
    • spec.system is not set in catalog-info.yaml. Add a system reference (e.g. payment-platform) that names a System registered in Backstage.

✅ 2 Passing

View all results in Grafana

@changeset-bot

changeset-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2706f7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.59%. Comparing base (682ee14) to head (efb2251).
⚠️ Report is 1 commits behind head on master.

⚠️ Current head efb2251 differs from pull request most recent head 2706f7a

Please upload reports for the commit 2706f7a to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1409   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         128      128           
  Lines        4162     4162           
  Branches     1036     1036           
=======================================
  Hits         3812     3812           
  Misses        350      350           
Flag Coverage Δ
browser 92.50% <ø> (ø)
core 90.07% <ø> (ø)
node 89.43% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@didiergarcia

Copy link
Copy Markdown

looks good

@MichaelGHSeg
MichaelGHSeg merged commit d549330 into master Nov 17, 2026
33 of 38 checks passed
@MichaelGHSeg
MichaelGHSeg deleted the fix/proxy-addr-curation branch November 17, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants