Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
* main: Add receipt / log reads to cryptosim (#3081) persist blocks and FullCommitQCs in data layer via WAL (CON-231) (#3126) Update Changelog in prep to cut v6.4.1 (#3213) fix(sei-tendermint): resolve staticcheck warnings (#3207) Add historical state offload stream hook (#3183) feat: wire autobahn config propagation from top-level to GigaRouter (CON-232) (#3194)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3218 +/- ##
==========================================
- Coverage 59.02% 58.96% -0.06%
==========================================
Files 2065 2060 -5
Lines 169414 168625 -789
==========================================
- Hits 99994 99432 -562
+ Misses 60673 60496 -177
+ Partials 8747 8697 -50
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
blindchaser
approved these changes
Apr 9, 2026
* main: fix: don't report block-level gas for failed tx decodes (CON-244) (#3205)
cody-littley
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Problem
While the PR fixes an old MemIAVL bug where ApplyChangeSets overwrote already pending changes, there is another potential issue with ApplyChangeSet:
ApplyChangeSet just appends the changeset to the WAL.
If there are subsequent ApplyChangeSet calls for the same store before committing, each would append an entry to the WAL and mutate the live tree.
This PR fixes ApplyChangeSet to make it behave the same as ApplyChangeSets by avoiding appending duplicate keys
Testing performed to validate your change
Added unit test