feat: add HTTPS support via Gateway sectionName#70
Closed
Conversation
Add SEI_GATEWAY_SECTION_NAME optional platform env var. When set, all HTTPRoute parentRefs include sectionName (e.g., "https") to target a specific Gateway listener for TLS termination. Rebased on the listener-model refactor — sectionName flows through the same generateHTTPRoute path as gatewayName/gatewayNamespace. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bdchatham
commented
Apr 9, 2026
| GatewayName: os.Getenv("SEI_GATEWAY_NAME"), | ||
| GatewayNamespace: os.Getenv("SEI_GATEWAY_NAMESPACE"), | ||
| GatewayDomain: os.Getenv("SEI_GATEWAY_DOMAIN"), | ||
| GatewaySectionName: os.Getenv("SEI_GATEWAY_SECTION_NAME"), |
Collaborator
Author
There was a problem hiding this comment.
Can we make this required?
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
SEI_GATEWAY_SECTION_NAMEoptional platform env var to target a specific Gateway listener (e.g.,"https") in HTTPRoute parentRefs.Rebased on the listener-model refactor (#69). The old PR (#68) had conflicts — this is a clean reimplementation on top of the current code.
Changes
internal/platform/platform.go— addGatewaySectionName(optional, not inValidate())cmd/main.go— readSEI_GATEWAY_SECTION_NAME, wire to reconcilerinternal/controller/nodedeployment/controller.go— add field to reconcilerinternal/controller/nodedeployment/networking.go— pass sectionName togenerateHTTPRoute, conditionally include in parentRefSupersedes #68.
Test plan
make testpassesmake lintpasses (0 issues)🤖 Generated with Claude Code