Skip to content

fix: restore configure-state-sync for S3 snapshot restores #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdchatham merged 1 commit into from
Apr 10, 2026
Merged

fix: restore configure-state-sync for S3 snapshot restores #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/controller/node/plan_execution_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ func TestIntegrationFullProgressionSnapshotMode(t *testing.T) {

driveTask(t, g, r, mock, fetch, planner.TaskConfigureGenesis)
driveTask(t, g, r, mock, fetch, planner.TaskConfigApply)
driveTask(t, g, r, mock, fetch, planner.TaskConfigureStateSync)
driveTask(t, g, r, mock, fetch, planner.TaskConfigValidate)
driveTask(t, g, r, mock, fetch, planner.TaskMarkReady)

Expand Down
10 changes: 5 additions & 5 deletions internal/controller/node/plan_execution_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ func TestBuildPlan_Snapshot(t *testing.T) {
p, _ := planner.ForNode(snapshotNode())
plan := mustBuildPlan(t, p, snapshotNode())
got := taskTypes(plan)
want := []string{planner.TaskSnapshotRestore, planner.TaskConfigureGenesis, planner.TaskConfigApply, planner.TaskConfigValidate, planner.TaskMarkReady}
want := []string{planner.TaskSnapshotRestore, planner.TaskConfigureGenesis, planner.TaskConfigApply, planner.TaskConfigureStateSync, planner.TaskConfigValidate, planner.TaskMarkReady}
assertProgression(t, got, want)
}

Expand All @@ -274,7 +274,7 @@ func TestBuildPlan_SnapshotWithPeers(t *testing.T) {
p, _ := planner.ForNode(node)
plan := mustBuildPlan(t, p, node)
got := taskTypes(plan)
want := []string{planner.TaskSnapshotRestore, planner.TaskConfigureGenesis, planner.TaskConfigApply, planner.TaskDiscoverPeers, planner.TaskConfigValidate, planner.TaskMarkReady}
want := []string{planner.TaskSnapshotRestore, planner.TaskConfigureGenesis, planner.TaskConfigApply, planner.TaskDiscoverPeers, planner.TaskConfigureStateSync, planner.TaskConfigValidate, planner.TaskMarkReady}
assertProgression(t, got, want)
}

Expand Down Expand Up @@ -311,7 +311,7 @@ func TestBuildPlan_Replayer(t *testing.T) {
p, _ := planner.ForNode(node)
plan := mustBuildPlan(t, p, node)
got := taskTypes(plan)
want := []string{planner.TaskSnapshotRestore, planner.TaskConfigureGenesis, planner.TaskConfigApply, planner.TaskDiscoverPeers, planner.TaskConfigValidate, planner.TaskMarkReady}
want := []string{planner.TaskSnapshotRestore, planner.TaskConfigureGenesis, planner.TaskConfigApply, planner.TaskDiscoverPeers, planner.TaskConfigureStateSync, planner.TaskConfigValidate, planner.TaskMarkReady}
assertProgression(t, got, want)
}

Expand All @@ -330,8 +330,8 @@ func TestBuildPlanPhaseAndTasks(t *testing.T) {
if plan.Phase != seiv1alpha1.TaskPlanActive {
t.Errorf("phase = %q, want Active", plan.Phase)
}
if len(plan.Tasks) != 5 {
t.Fatalf("expected 5 tasks, got %d: %v", len(plan.Tasks), taskTypes(plan))
if len(plan.Tasks) != 6 {
t.Fatalf("expected 6 tasks, got %d: %v", len(plan.Tasks), taskTypes(plan))
}
for _, pt := range plan.Tasks {
if pt.Status != seiv1alpha1.TaskPending {
Expand Down
2 changes: 1 addition & 1 deletion internal/planner/bootstrap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func buildBootstrapProgression(peers []seiv1alpha1.PeerSource, snap *seiv1alpha1
if len(peers) > 0 {
prog = insertBefore(prog, TaskConfigValidate, TaskDiscoverPeers)
}
if hasStateSync(snap) {
if snap != nil {
prog = insertBefore(prog, TaskConfigValidate, TaskConfigureStateSync)
}

Expand Down
2 changes: 1 addition & 1 deletion internal/planner/planner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ func buildBasePlan(
if len(peers) > 0 {
prog = insertBefore(prog, TaskConfigValidate, TaskDiscoverPeers)
}
if hasStateSync(snap) {
if snap != nil {
prog = insertBefore(prog, TaskConfigValidate, TaskConfigureStateSync)
}

Expand Down
2 changes: 1 addition & 1 deletion manifests/samples/seinode/pacific-1-shadow-replayer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ spec:
bootstrapImage: "ghcr.io/sei-protocol/sei:v6.3.0"
trustPeriod: "9999h0m0s"
resultExport:
canonicalRpc: "http://pacific-1-archive-0.pacific-1-archive.default.svc.cluster.local:26657"
canonicalRpc: "http://rpc.pacific-1.prod.platform.sei.io:26657"
Loading