Repository navigation
Conversation
Author
|
Hi maintainers! I rechecked this against current I've refreshed the PR description with the results and the separate native-Windows full-suite limitations. The CI workflow is still awaiting approval. Could someone please approve the workflow and review the fix when convenient? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #110
Summary
On native Windows, background jobs cannot be cancelled because their PID identity is missing; once an identity is available, cancellation still takes the Unix process-group path. This change fixes both steps:
taskkill /T /Fprocess-tree helper.Verification
Revalidated on 2026-10-14 with native Windows and Node.js 24.17.0 at
9a60624a82d43749a03536ef9f83d0324bbc6eb3. The branch already contains currentmain(19e565151f35b328a5b9433df351bd8f3818fdc7), so no merge or rebase was needed.npm cicompleted.npm run test:cross-platform: 299 passed, 0 failed.npm run lint,npm run typecheck,npm run check:version-sync, andnpm run check:changelogpassed as the initial stages ofnpm run check.claude.exe, Bash, and Node process tree.The full
npm run checkis not reported as passing on this Windows host. Its broader unit suite encountered Windows failures and was stopped before integration/e2e. The repository runs this full suite on Linux/macOS and the curated suite above on Windows; Linux/macOS CI still needs maintainer approval. The additional failures were:codex-config:retries writable-root updates without losing a concurrent config changefails inafterEachtemporary-directory cleanup withEPERM. The same failure was reproduced against an untouched archive of currentmain.git:gracefully handles untracked directory contents and symlinks in working-tree review contextfails creating a symlink withEPERM. The twoomits very large ... diffstests anddegrades gracefully when working-tree diff output exceeds the process bufferfail in temporary-directory cleanup withEPERM. These test cases andscripts/lib/git.mjsare unchanged frommain.