feat: add new Google Batch CE and credential features [COMP-1463]#604
Draft
ramonamela wants to merge 2 commits intomasterfrom
Draft
feat: add new Google Batch CE and credential features [COMP-1463]#604ramonamela wants to merge 2 commits intomasterfrom
ramonamela wants to merge 2 commits intomasterfrom
Conversation
- WIF (Workload Identity Federation) support for Google credentials with --mode=workload-identity, --service-account-email, --workload-identity-provider, and --token-audience options - Network tags (--network-tags) with VPC requirement and GCP format validation, plus --network and --subnetwork options - Machine type selection: --head-job-machine-type (single) and --compute-jobs-machine-type (comma-separated list with wildcard support), mutually exclusive with instance templates - Boot disk image (--boot-disk-image) with format validation for projects/*/global/images/*, family paths, and batch-* short names - Fusion Snapshots (--fusion-snapshots) toggle requiring Fusion v2 All features include CLI validation matching backend/frontend rules. Code will compile once tower-java-sdk is bumped to include the new fields on GoogleSecurityKeys and GoogleBatchConfig. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Upgrade tower-java-sdk from 1.114.0 to 1.133.0 to include new fields on GoogleSecurityKeys and GoogleBatchConfig - Add bash integration test script for all COMP-1463 features Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes COMP-1463 — Make new platform features available via CLI.
--mode=workload-identitywith--service-account-email,--workload-identity-provider,--token-audienceoptions for Google credentials (PR #10346)--network-tags(comma-separated) with--network/--subnetworkoptions and GCP format validation (PR #10416)--head-job-machine-type(single) and--compute-jobs-machine-type(comma-separated, wildcard support), mutually exclusive with instance templates (PRs #10488, #10532)--boot-disk-imagewith format validation for project paths, family paths, and batch short names (PR #10484)--fusion-snapshotstoggle requiring--fusion-v2(PR #10751)All features include CLI-side validation matching backend/frontend rules.
Pending
tower-java-sdkto a version that includes the new fields onGoogleSecurityKeys(serviceAccountEmail,workloadIdentityProvider,tokenAudience) andGoogleBatchConfig(networkTags,computeJobsMachineType,bootDiskImage,fusionSnapshots)Test plan
🤖 Generated with Claude Code