Skip to content

Update code guidelines from platform #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Micha Hobert (Isengo1989) merged 1 commit into from
Apr 13, 2026
+2 −0
Merged

Update code guidelines from platform #2235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions resources/guidelines/code/core/database-migations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,8 @@ To make those tests fast to run and easier to understand you should not use any
You should also especially not rely on the kernel being booted and the service container being available.
To test your migration you can get a database connection via `KernelLifecycleManager::getConnection()`.
Besides obviously relying on the database, the migration tests should behave like unit tests and rely on nothing else external.
Migration tests should verify idempotence by executing the migration's `update()` method twice whenever that is feasible for the migration under test.
When a migration test needs to create multiple fixture rows, prefer `MultiInsertQueryQueue` to reduce database round-trips and write overhead. This is recommended, but optional.

**Be careful with implicit commits**

Expand Down