Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pose_to_segments --videosets a MIME type only for videos ending in lowercase.mp4. For any other video it passesmimetype=None, so pympi guesses the type from its own short list of extensions. That list has no .mov and is case-sensitive, so linking a .mov or .MP4 video crashes. This PR looks up the lowercase extension in a table of common video types (mp4, mov, mpg/mpeg, avi, wmv, mkv, webm) and falls back tovideo/<extension>for anything else.Note that my previous PR and this change neighbouring lines in `main(), so the one merged second may need a small conflict resolved.