Open
Conversation
There was a problem hiding this comment.
Pull request overview
Documents and aligns local developer/agent guidance with CI whitespace and commit-message checks, and updates the local whitespace fixer to preserve UTF-8 BOM to avoid unnecessary diffs.
Changes:
- Preserve UTF-8 BOM when rewriting files in
fix-whitespace.ps1. - Clarify that whitespace validation is based on commit history (
origin/main..HEAD) incheck-whitespace.ps1. - Update repository/agent instructions to prefer VS Code “CI:*” tasks for local CI parity.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Build/Agent/fix-whitespace.ps1 | Detect and preserve UTF-8 BOM when re-writing files; improve user guidance output. |
| Build/Agent/check-whitespace.ps1 | Clarify commit-range semantics and remediation steps in whitespace failure output. |
| AGENTS.md | Add CI parity task guidance and update the validation checklist. |
| .github/instructions/terminal.instructions.md | Prefer CI parity VS Code tasks over ad-hoc shell commands. |
| .github/instructions/repo.instructions.md | Add succinct CI parity rules for whitespace and commit-message checks. |
Comment on lines
+34
to
35
| $hasUtf8Bom = Test-HasUtf8Bom -Path $Path | ||
| try { |
Comment on lines
+16
to
+17
| $bytes = [System.IO.File]::ReadAllBytes($Path) | ||
| return $bytes.Length -ge 3 -and $bytes[0] -eq 0xEF -and $bytes[1] -eq 0xBB -and $bytes[2] -eq 0xBF |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
This change is