Remove all remaining hard-coded values (issue #393)#452
Merged
justin-ven merged 1 commit intodevelopfrom Apr 14, 2026
Merged
Conversation
Contributor
|
At line 640, age 21 seems to be hard-coded. Appreciate that this may not be important, but guess that it could be removed fairly easily as part of this pull request? |
Collaborator
Author
Strictly speaking, yes, as it is a literal number instead of a parameter. However, there is no corresponding parameter, either for this value or for any other bound used to create the age groups. |
Contributor
|
Could you add a parameter somewhere near where one of the other age parameters is located? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.