Conversation
Remove the SocialCareProvision enum and associated discrete provision state/flags across the model. Replace reliance on a care-provision label with checks of careHrsProvidedWeek (and a simple careProvided int where needed), remove the SocialCareAlignment class and the SocialCareMarketClearing process, and stop loading the CareProvisionAdjustment timeseries. Update expectations, decision grid, manager/grids export, and states code to omit the provision axis; adjust DataParser migration SQL to drop the old careProvidedFlag column handling. Also switch several stochastic/regression transforms from exp(...) to sinh(...), and update innovation draw indices and related uses to match the new flows. This simplifies social-care handling to use hours-based logic and removes the root-search based alignment step.
justin-ven
reviewed
May 5, 2026
Contributor
There was a problem hiding this comment.
These changes all look spurious
justin-ven
reviewed
May 5, 2026
Contributor
There was a problem hiding this comment.
This adjustment looks spurious
justin-ven
reviewed
May 5, 2026
| evaluateSocialCareReceipt(); | ||
| } | ||
| case SocialCareProvision -> { | ||
| evaluateSocialCareProvision(); |
Contributor
There was a problem hiding this comment.
This replace looks spurious
justin-ven
reviewed
May 5, 2026
| careFormalX = 0.0; | ||
| } | ||
|
|
||
| protected void evaluateSocialCareProvision() { |
Contributor
There was a problem hiding this comment.
This deletion looks spurious
justin-ven
reviewed
May 5, 2026
| @@ -5148,10 +5092,6 @@ public Long getPartnerID() { | |||
| private void nullPartnerVariables() { | |||
|
|
|||
Contributor
There was a problem hiding this comment.
This method no longer needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the SocialCareProvision enum and associated discrete provision state/flags across the model. Replace reliance on a care-provision label with checks of careHrsProvidedWeek (and a simple careProvided int where needed), remove the SocialCareAlignment class and the SocialCareMarketClearing process, and stop loading the CareProvisionAdjustment timeseries. Update expectations, decision grid, manager/grids export, and states code to omit the provision axis; adjust DataParser migration SQL to drop the old careProvidedFlag column handling. Also switch several stochastic/regression transforms from exp(...) to sinh(...), and update innovation draw indices and related uses to match the new flows. This simplifies social-care handling to use hours-based logic and removes the root-search based alignment step.