Closed
Conversation
Just an initial rewrite, still needs to be checked.
Member
|
Thank you for hitting this. I've run a few tests using this with WB. A few questions/notes.
I noticed a few issues with the build:
After making a build, the generated |
Member
Author
|
Thanks Alex! I'll get on all the fixes in the morning. It's possible we can resolve the |
Member
Author
|
I'm going to put this aside for now, but I'll leave this open in case we ever need to finish off a transition to Gulp 5 for some reason. Something in the steps from copying to the tmp directory and then the dist directory is just not working the same as before, and I can't figure it out. |
Member
|
Closed in favor of #52. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates us to Gulp 5. I haven't fully checked the ZIP file it creates, but everything seems good at first glance.
The command is slightly different.
You can see the scripts for all other available scripts
This still needs quite a bit of checking, so we can consider it a WIP.