Merged
Conversation
- Default --with-kill to true (force exit after 3 interrupts) - Unhide the flag so users can disable with --with-kill=false - Fix isFatalHTTPErr: treat context.Canceled as fatal (was only checking DeadlineExceeded, so Ctrl+C signal was ignored) - Fix retry sleep to respect context cancellation - Add context check at top of outer retry loop
…P over dmsg - Test dmsg curl with -B (direct client, no discovery) - Test dmsg curl with -S (specific server) - Test HTTP server endpoints (/, /health, /echo) served over dmsg - Test discovery health and server registration - Wait for server registration before running tests - Replace sleep-based waits with polling for discovery readiness
The dmsg-server Dockerfile had a PK that didn't match its SK, so every PostEntry to the discovery was rejected with "invalid signature". The server could never register, causing all E2E tests to time out waiting for it. Generate a valid keypair and use discovery IP directly to avoid DNS.
Usage: dmsg conf gen-keys - generate a new PK/SK pair dmsg conf verify-keys <sk> - derive PK from SK to verify config files
When a debug dmsg client runs on a dmsg server (using the same PK), the discovery entry lookup returns the server's entry which has Client: nil. Accessing entry.Client.DelegatedServers panicked. Now handles nil Client by creating a fresh client entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.